Refactor code structure for improved readability and maintainability

[kanywst]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @kanywst, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing the project's development tooling and enhancing the user experience on the issues page. It involves a significant refactor of the ESLint setup to adopt the new flat configuration, alongside comprehensive updates to core dependencies. Concurrently, a new date filtering feature has been implemented, providing users with more granular control over issue search results, complemented by new tests to ensure stability and functionality.

Highlights

• ESLint Configuration Migration: The project's ESLint configuration has been migrated from the legacy .eslintrc.json format to the modern flat config format (eslint.config.mjs), incorporating new plugins and updated rules.
• New Date Filtering Feature: A new date filter has been introduced on the issues page, allowing users to filter 'good first issues' by their creation date (e.g., 'Last 24 hours', 'Last 7 days').
• Dependency Updates: Numerous project dependencies, including Next.js, React, Material UI, Octokit, Tanstack Query, Zod, Playwright, and various ESLint-related packages, have been updated to their latest versions.
• Enhanced Testing: New unit tests for the GitHub client and an E2E test for the date filter functionality have been added, improving test coverage and ensuring feature correctness.
• Expanded Language Options: The list of popular programming languages available for filtering issues has been expanded to include more options like Mojo, Zig, Gleam, Carbon, Kotlin, Swift, C++, and Ruby.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• .eslintrc.json
  • Removed the legacy ESLint configuration file.
• e2e/issues.spec.ts
  • Added a new Playwright E2E test to verify the visibility and interaction of the date filter on the issues page.
• eslint.config.mjs
  • Migrated ESLint configuration to the new flat config format.
  • Integrated @eslint/js, typescript-eslint, @next/eslint-plugin-next, eslint-plugin-react, and eslint-plugin-react-hooks.
  • Updated ignore patterns to include test-results and playwright-report.
  • Configured various ESLint rules for improved code quality.
• package.json
  • Updated the lint script from next lint to eslint src to align with the new ESLint configuration.
  • Bumped versions for @emotion/styled, @mui/icons-material, @mui/material, @octokit/core, @tanstack/react-query, next, react, react-dom, zod, @eslint/eslintrc, @playwright/test, @testing-library/react, @types/node, @vitejs/plugin-react, eslint-config-next, jsdom, prettier, and vitest.
• playwright-report/index.html
  • Updated Playwright report artifact, likely due to Playwright version update or new test run.
• src/app/error.tsx
  • Renamed the error prop to _error in ErrorPage to suppress unused variable warnings, aligning with ESLint rules.
• src/features/issues/IssuesPage.tsx
  • Expanded the POPULAR_LANGUAGES list with additional programming languages.
  • Introduced DATE_FILTERS array for date-based filtering options.
  • Added days state and handleDaysChange function to manage date filter selection.
  • Modified useQuery to include days in the queryKey and added isFetching for better loading state management.
  • Implemented a 'Total Count Display' to show the number of found issues.
  • Added a new FormControl with a Select component for date filtering.
  • Updated the search IconButton to display a CircularProgress during loading/fetching and to be disabled during these states.
  • Adjusted pagination count calculation to Math.min(issuesData?.total_count || 0, 1000) to respect GitHub API's 1000-issue limit for search results.
• src/lib/api/github-client.test.ts
  • Added a new unit test file for github-client.ts.
  • Included tests to verify that getGoodFirstIssues correctly incorporates language, keyword, and the new days filter into the GitHub API query.
• src/lib/api/github-client.ts
  • Added a days parameter to the getGoodFirstIssues function.
  • Modified the GitHub API query to include created:<=${dateString} when days is provided, allowing filtering of issues by creation date.
• test-results/.last-run.json
  • Updated test results artifact.
• tsconfig.json
  • Updated the lib compiler option to use an array format.
  • Changed the jsx compiler option from preserve to react-jsx.
  • Added .next/dev/types/**/*.ts to the include paths for better type resolution in development.

Activity

• No specific activity (comments, reviews, progress) was provided in the context for this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[kanywst]

/gemini review

[gemini-code-assist]

Code Review

This pull request significantly refactors the project's structure and enhances functionality. The migration to ESLint flat configuration is a robust improvement for code quality and maintainability. The addition of date and stars filters, along with their corresponding API logic and e2e tests, greatly improves the user experience for discovering issues. Dependency updates and minor stylistic changes also contribute to a more modern and stable codebase. Overall, the changes are well-implemented and demonstrate a strong focus on both developer experience and user functionality.