int overflow safe

Signed-off-by: Aaron Alpar <[email protected]>
kanisterio · Jan 17, 2025 · 8a62402 · 8a62402
1 parent 9f0e874
commit 8a62402
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/pkg/kando/process_client_signal.go b/pkg/kando/process_client_signal.go
@@ -40,11 +40,11 @@ func runProcessClientSignal(cmd *cobra.Command, args []string) error {
 }
 
 func runProcessClientSignalWithOutput(out io.Writer, cmd *cobra.Command, args []string) error {
-	pid, err := strconv.Atoi(args[0])
+	pid, err := strconv.ParseInt(args[0], 0, 64)
 	if err != nil {
 		return err
 	}
-	signal, err := strconv.Atoi(args[1])
+	signal, err := strconv.ParseInt(args[1], 0, 64)
 	if err != nil {
 		return err
 	}
@@ -54,7 +54,7 @@ func runProcessClientSignalWithOutput(out io.Writer, cmd *cobra.Command, args []
 	}
 	asJSON := processAsJSONFlagValue(cmd)
 	cmd.SilenceUsage = true
-	p, err := kanx.SignalProcess(cmd.Context(), addr, int64(pid), int32(signal))
+	p, err := kanx.SignalProcess(cmd.Context(), addr, pid, signal)
 	if err != nil {
 		return err
 	}

diff --git a/pkg/kanx/client.go b/pkg/kanx/client.go
@@ -80,7 +80,7 @@ func ListProcesses(ctx context.Context, addr string) ([]*Process, error) {
 	}
 }
 
-func SignalProcess(ctx context.Context, addr string, pid int64, signal int32) (*Process, error) {
+func SignalProcess(ctx context.Context, addr string, pid int64, signal int64) (*Process, error) {
 	conn, err := newGRPCConnection(addr)
 	if err != nil {
 		return nil, err

diff --git a/pkg/kanx/kanx.pb.go b/pkg/kanx/kanx.pb.go
diff --git a/pkg/kanx/kanx.proto b/pkg/kanx/kanx.proto
@@ -27,7 +27,7 @@ message ProcessPidRequest {
 
 message SignalProcessRequest {
   int64 pid = 1;
-  int32 signal = 2;
+  int64 signal = 2;
 }
 
 message Process {