Use rel="noopener noreferrer" for external links

kamilmielnik · Apr 8, 2020 · 49631a2 · 49631a2
1 parent 3eb68be
commit 49631a2
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "cv",
-  "version": "1.6.1",
+  "version": "1.6.2",
   "description": "Kamil Mielnik's Curriculum Vitae",
   "engines": {
     "node": ">=12.4.0"
@@ -74,7 +74,7 @@
     "http-server": "^0.12.1",
     "node-sass": "^4.13.1",
     "node-ssh": "^8.0.0",
-    "prettier": "^2.0.2",
+    "prettier": "^2.0.4",
     "puppeteer": "^2.1.1",
     "react-scripts": "^3.4.1",
     "rimraf": "^3.0.2",

diff --git a/src/components/ContactInfo/ContactInfoEntry/ContactInfoEntry.tsx b/src/components/ContactInfo/ContactInfoEntry/ContactInfoEntry.tsx
@@ -13,7 +13,7 @@ const ContactInfoEntry: FunctionComponent<Props> = ({ label, url, value }) => (
     <div className={styles.label}>{label}</div>
 
     {url && (
-      <a className={styles.value} href={url}>
+      <a className={styles.value} href={url} rel="noopener noreferrer">
         {value}
       </a>
     )}

diff --git a/src/components/Experience/ExperienceEntry/Info/Info.tsx b/src/components/Experience/ExperienceEntry/Info/Info.tsx
@@ -14,7 +14,9 @@ interface Props {
 const Info: FunctionComponent<Props> = ({ className, location, organization, timePeriod, url }) => (
   <div className={classNames(styles.info, className)}>
     <h3 className={styles.organization}>
-      <a href={url}>{organization}</a>
+      <a href={url} rel="noopener noreferrer">
+        {organization}
+      </a>
     </h3>
 
     <div className={styles.details}>