-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: added support for locking checkboxes #1242
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm loving the feature. We've received often the request to make a way to not reset some options after each use, and we've also got the request to clear the sneak attack after each use... I've never thought of a simple way to do it.. I was leaning towards making those into dropdowns instead of toggles, but I love your approach and I think it works really well!
I'd say, add the "(apply to next roll)" text on the cunning strike label, since that should have been there, and add a lock
option for all of the other options that have "apply to next roll" in them.
Would also love to have the lock option added to the rogue-sneak-attack
option (but with default: true
so we don't change the expected behavior.
added missing text on cunning strike setting fixed expression for sneak and cunning strike
…ng text and reset feature to 2024
Hey @kakaroto , Thanks so much for the suggestions! I'm really glad you loved the idea - that means a lot. 🙌 I went ahead and made all the changes you suggested. The label for Cunning Strike now includes the "(apply to next roll)" text, as it should’ve from the start. I've also added the lock option to all other settings that include "apply to next roll," just as you requested. And yes! The rogue-sneak-attack option now has a lock as well, with the default set to true, so the expected behavior remains unchanged. Let me know if there's anything else you'd like adjusted! |
Warning
Hi @kakaroto what do you think about this? I made it as separate setting because i didnt want to have to deal with merging of settings from stored character settings already etc, and i didnt want to create another setting type, so i opted to add the "lock" setting to the bool option types as a reference to another setting that is not displayed separately. see this ticket as reference for the feature - #1241
Important
Code is not optimized yet just wanted to get you to give an eyeball at it
Feature
Sneak Attack
Padlock
Note
Padlock will override the reverting of the setting on all uses including when cunning strike is set by a hotkey