Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add E2E Endpoint Checks #864

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

feat: Add E2E Endpoint Checks #864

wants to merge 22 commits into from

Conversation

ishaansehgal99
Copy link
Collaborator

Reason for Change:
Add checks for checking two endpoints validateCompletionsEndpoint and validateModelsEndpoint

zhuangqh
zhuangqh requested changes Feb 4, 2025
View reviewed changes
test/e2e/preset_test.go Show resolved Hide resolved
zhuangqh
zhuangqh requested changes Feb 5, 2025
View reviewed changes
test/e2e/e2e_test.go
@@ -33,6 +33,7 @@ var _ = BeforeSuite(func() {
GinkgoWriter.Printf("Namespace %q for e2e tests\n", namespaceName)

kaitoNamespace := os.Getenv("KAITO_NAMESPACE")
Expect(createCurlDebugPod(kaitoNamespace)).To(Succeed(), "Failed to create curl debug pod")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use namespaceName this one.😀

test/e2e/preset_test.go
}, existingPod)

if err == nil {
By(fmt.Sprintf("Debug pod %s already exists", curlPodName))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
By(fmt.Sprintf("Debug pod %s already exists", curlPodName))
It(fmt.Sprintf("Debug pod %s already exists", curlPodName))

test/e2e/preset_test.go
Name: "curl-container",
Image: "curlimages/curl",
Command: []string{
"sleep", "3600", // Keeps the pod running for long enough
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sleep "infinity"
this e2e usually last more than one hour 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhuangqh zhuangqh zhuangqh requested changes

@Fei-Guo Fei-Guo Fei-Guo approved these changes

@helayoty helayoty Awaiting requested review from helayoty helayoty is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ishaansehgal99 @zhuangqh @Fei-Guo