Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE: Impl custom auth page #402

Merged
merged 15 commits into from
Dec 28, 2024
Merged

FE: Impl custom auth page #402

merged 15 commits into from
Dec 28, 2024

Conversation

Nilumilak
Copy link
Member

@Nilumilak Nilumilak commented May 20, 2024 •
edited
Loading

resolves #72

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Nilumilak Nilumilak self-assigned this May 20, 2024
@Nilumilak Nilumilak requested a review from a team as a code owner May 20, 2024 13:10
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels May 20, 2024
@Nilumilak Nilumilak added scope/frontend Related to frontend changes type/enhancement En enhancement/improvement to an already existing feature labels May 20, 2024
@Haarolean Haarolean marked this pull request as draft May 20, 2024 17:31
@Haarolean Haarolean added the hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved label Oct 4, 2024
@Haarolean Haarolean mentioned this pull request Oct 25, 2024
Merged
13 tasks
@Nilumilak Nilumilak force-pushed the feature/auth_page branch 2 times, most recently from aa6667d to 23cea5e Compare December 17, 2024 09:26
@Haarolean Haarolean marked this pull request as ready for review December 17, 2024 09:31
@Haarolean Haarolean requested review from a team as code owners December 17, 2024 09:31
@Haarolean Haarolean assigned Haarolean and unassigned Nilumilak Dec 17, 2024
Leshe4ka
Leshe4ka reviewed Dec 17, 2024
View reviewed changes
frontend/src/components/AuthPage/SignIn/OAuthSignIn/AuthCard/AuthCard.tsx Outdated
<S.ServiceButton
buttonSize="L"
buttonType="primary"
to={`http://localhost:8080${authPath}`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like better to set this as env var

Leshe4ka
Leshe4ka reviewed Dec 17, 2024
View reviewed changes
frontend/vite.config.ts
'/auth': {
target: isProxy,
changeOrigin: true,
secure: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check this flag and pass proxy config to prod mode.

@Haarolean Haarolean added area/auth App authentication related issues and removed status/triage/manual Manual triage in progress labels Dec 17, 2024
@Haarolean Haarolean assigned Nilumilak and unassigned Haarolean Dec 17, 2024
@Haarolean Haarolean changed the title Implement an authentication page FE: Auth: Implement an authentication page Dec 17, 2024
@Haarolean Haarolean changed the base branch from main to auth_page_be December 17, 2024 14:50
@Haarolean Haarolean removed the request for review from a team December 17, 2024 15:10
@Haarolean Haarolean self-requested a review December 24, 2024 20:25
Base automatically changed from auth_page_be to auth_page_merge December 28, 2024 04:04
@Haarolean Haarolean changed the base branch from auth_page_merge to main December 28, 2024 04:05
@Haarolean Haarolean changed the base branch from main to auth_page_merge December 28, 2024 04:10
@Haarolean Haarolean force-pushed the feature/auth_page branch 3 times, most recently from c8365fb to 37d5c9c Compare December 28, 2024 04:17
@Haarolean Haarolean changed the title FE: Auth: Implement an authentication page FE: Impl custom auth page Dec 28, 2024
@Haarolean Haarolean merged commit 79d3ca9 into auth_page_merge Dec 28, 2024
9 of 10 checks passed
@Haarolean Haarolean deleted the feature/auth_page branch December 28, 2024 04:19
Haarolean added a commit that referenced this pull request Dec 28, 2024
@Nilumilak @Haarolean
FE: Impl custom auth page (#402)
21edbf7 
Co-authored-by: Roman Zabaluev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leshe4ka Leshe4ka Leshe4ka left review comments

@Haarolean Haarolean Haarolean approved these changes

Assignees

@Nilumilak Nilumilak

Labels
area/auth App authentication related issues hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auth: Impl an authentication page
3 participants
@Nilumilak @Haarolean @Leshe4ka