Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth: Impl an authentication page #72

Closed
Haarolean opened this issue Jan 30, 2024 · 0 comments · Fixed by #402 or #635
Closed

Auth: Impl an authentication page #72

Haarolean opened this issue Jan 30, 2024 · 0 comments · Fixed by #402 or #635
Assignees
@Haarolean @Nilumilak
Labels
area/auth App authentication related issues scope/backend Related to backend changes scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Milestone
1.1

Comments

@Haarolean
Copy link
Member

Haarolean commented Jan 30, 2024 •
edited
Loading

  • Get rid of AuthController, do that on the frontend instead.
  • Get rid of the default spring security login page
  • Leave the csrf endpoint public, call when needed from the frontend.
  • Impl a custom auth page for all the auth methods (oauth, ldap, basic)

Should fix:
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress labels Jan 30, 2024
@kapybro kapybro bot added scope/frontend Related to frontend changes status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jan 30, 2024
@Haarolean Haarolean assigned Haarolean and unassigned germanosin Jan 30, 2024
@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/backend Related to backend changes type/refactor Refactoring task and removed status/triage/manual Manual triage in progress labels Jan 31, 2024
@Haarolean Haarolean removed their assignment Jan 31, 2024
@Haarolean Haarolean added this to the 1.1 milestone Jan 31, 2024
@Haarolean Haarolean moved this to Beginner in Up for grabs Jan 31, 2024
@Haarolean Haarolean changed the title Get rid of AuthController Get rid of the OAuth AuthController Feb 7, 2024
@Haarolean Haarolean added status/pending-design Pending UI design solution and removed good first issue Up for grabs status/pending-frontend labels Mar 12, 2024
@Haarolean Haarolean self-assigned this Mar 12, 2024
@Haarolean Haarolean removed this from Up for grabs Mar 12, 2024
@Haarolean Haarolean changed the title Get rid of the OAuth AuthController Implement an authentication page Mar 25, 2024
@Haarolean Haarolean added status/pending-backend and removed status/pending-design Pending UI design solution type/refactor Refactoring task labels Apr 26, 2024
@Haarolean Haarolean moved this from Pending Requirements to Dev Implementation in UI/UX Design Solutions Oct 18, 2024
@Haarolean Haarolean added the area/auth App authentication related issues label Oct 25, 2024
@Haarolean Haarolean moved this from In Development to In Review in Release 1.1 Oct 25, 2024
@Haarolean Haarolean mentioned this issue Oct 25, 2024
Merged
13 tasks
@Haarolean Haarolean linked a pull request Oct 25, 2024 that will close this issue
BE: Impl custom authentication page #635
Merged
13 tasks
@Haarolean Haarolean assigned Nilumilak and unassigned Haarolean Oct 29, 2024
@Haarolean Haarolean moved this from In Review to In Development in Release 1.1 Oct 29, 2024
@Haarolean Haarolean mentioned this issue Oct 30, 2024
Closed
4 tasks
Nilumilak added a commit that referenced this issue Dec 17, 2024
@Nilumilak
resolves #72
df68c5f
@Haarolean Haarolean mentioned this issue Dec 17, 2024
Closed
2 tasks
@Haarolean Haarolean moved this from In Development to In Review in Release 1.1 Dec 17, 2024
Haarolean pushed a commit that referenced this issue Dec 17, 2024
@Nilumilak @Haarolean
resolves #72
2ae2327
Haarolean pushed a commit that referenced this issue Dec 17, 2024
@Nilumilak @Haarolean
resolves #72
cecfab3
Haarolean pushed a commit that referenced this issue Dec 17, 2024
@Nilumilak @Haarolean
resolves #72
3e61608
@Haarolean Haarolean moved this from In Review to Changes requested in Release 1.1 Dec 24, 2024
Haarolean pushed a commit that referenced this issue Dec 28, 2024
@Nilumilak @Haarolean
resolves #72
8d67d51
Haarolean pushed a commit that referenced this issue Dec 28, 2024
@Nilumilak @Haarolean
resolves #72
2993327
Haarolean pushed a commit that referenced this issue Dec 28, 2024
@Nilumilak @Haarolean
resolves #72
3eca3e8
@Haarolean Haarolean changed the title Implement an authentication page Auth: Impl an authentication page Dec 28, 2024
@Haarolean Haarolean self-assigned this Dec 28, 2024
@Haarolean Haarolean moved this from Changes requested to PR Approved in Release 1.1 Dec 28, 2024
@Haarolean Haarolean moved this from Dev Implementation to Design Impl Review in UI/UX Design Solutions Dec 28, 2024
@github-project-automation github-project-automation bot moved this from Design Impl Review to Done in UI/UX Design Solutions Dec 28, 2024
@github-project-automation github-project-automation bot moved this from PR Approved to Done in Release 1.1 Dec 28, 2024
@Haarolean Haarolean moved this from Done to Design Impl Review in UI/UX Design Solutions Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Haarolean Haarolean

@Nilumilak Nilumilak

Labels
area/auth App authentication related issues scope/backend Related to backend changes scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
UI/UX Design Solutions
Status: Design Impl Review
Release 1.1
Status: Done
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

FE: Impl custom auth page kafbat/kafka-ui
BE: Impl custom authentication page kafbat/kafka-ui
3 participants
@germanosin @Haarolean @Nilumilak