Integration test suite #317
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Panattoni <[email protected]>
Signed-off-by: Andrea Panattoni <[email protected]>
Signed-off-by: Andrea Panattoni <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| f, err := os.OpenFile(p.methodCallsRecordingFilePath, | ||
| os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644) | ||
| if err != nil { | ||
| log.Println(err) |
Check warning
Code scanning / CodeQL
Writable file handle closed without error handling Warning test
zeeke
force-pushed
the
us/integration-tests
branch
3 times, most recently
from
819bcfa to
423fe1c
Compare
Pull Request Test Coverage Report for Build 13185028153Details
💛 - Coveralls |
zeeke
force-pushed
the
us/integration-tests
branch
4 times, most recently
from
d8f433c to
7c1f069
Compare
zeeke
force-pushed
the
us/integration-tests
branch
4 times, most recently
from
c452d90 to
67498c8
Compare
SchSeba
reviewed
Feb 6, 2025
test/integration/test_sriov_cni.sh
Outdated
|
|
||
| make_container "container_1" | ||
|
|
||
| export CNI_NETNS=/run/netns/container_1_netns |
There was a problem hiding this comment.
is it possible to move this export inside the make_container or it doesn't work like that in bash? :P
There was a problem hiding this comment.
surprisingly, it works! and it make the code cleaner. fixing
| export CNI_COMMAND=ADD | ||
| assert invoke_sriov_cni | ||
| assert_file_contains "${DEFAULT_CNI_DIR}/enp175s0f1.calls" "LinkSetVfVlanQosProto enp175s0f1 0 1234 0 33024" | ||
|
|
There was a problem hiding this comment.
I think we need to remove this file after every test no?
There was a problem hiding this comment.
it's not mandatory, because the setup() function creates a different DEFAULT_CNI_DIR at every test:
setup() {
...
DEFAULT_CNI_DIR=$(mktemp -d)
export DEFAULT_CNI_DIR
}
But it is still a good practice. Adding a teardown() function
zeeke
force-pushed
the
us/integration-tests
branch
from
67498c8 to
411069b
Compare
Having a test suite that covers the code from an out-of-process perspective helps in testing specific scenarios, e.g. when the concurrency of multiple program instances occurs. Also, using test doubles instead of real SR-IOV capable NICs makes tests fast and portable, in a way that can be run at every commit. Add a test suite that invokes a system-mocked version of the sriov CNI binary, in which the `/sys` filesystem content is defined at code, and the network interfaces are of type dummy. Add `test-integration` make target to invoke the test suite. Signed-off-by: Andrea Panattoni <[email protected]>
Signed-off-by: Andrea Panattoni <[email protected]>
zeeke
force-pushed
the
us/integration-tests
branch
from
411069b to
802de56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a test suite that covers the code from an out-of-process perspective helps
in testing specific scenarios, e.g. when the concurrency of multiple program instances
occurs. Also, using test doubles instead of real SR-IOV capable NICs makes tests fast
and portable, in a way that can be run at every commit.
Add a test suite that invokes a system-mocked version of the sriov CNI binary, in which
the
/sysfilesystem content is defined at code, and the network interfaces are of type dummy.Add
test-integrationmake target to invoke the test suiteMove cni commands to pkg/cnicommands package
Allow injecting NetlinkManager in SriovManager
refer to the README.md file for the test architecture