-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip setting vlan when parameter is not present #296
Conversation
683eef3
to
b964e3f
Compare
Pull Request Test Coverage Report for Build 8924595799Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!
please just extend a bit more our unit test to cover all the cases related to vlans
*conf.Vlan,
*conf.VlanQoS,
sriovtypes.VlanProtoInt[*conf.VlanProto]
to be sure we call the function when needed (vlan is not empty)
Thanks @SchSeba . There are many cases related to vlan in config_test.go. Regarding the calling of the function, yes, there is one missing case, so I added unit tests for ApplyVFConfig which covers all optional parameters. |
@Eoghan1232, @e0ne, please have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nice work!
Fixes k8snetworkplumbingwg#291 Signed-off-by: Marcelo Guerrero <[email protected]>
Signed-off-by: Marcelo Guerrero <[email protected]>
Hi @adrianchiris, could you please have a look at this? Thanks! |
working my way through my emails now, so getting around to the PR's |
Fixes #291