Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release workflow #287

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Fix release workflow #287

merged 1 commit into from
Nov 29, 2023

Conversation

adrianchiris
Copy link
Contributor

  • remove "latest" image tage from docker meta
  • remove use of IMAGE_NAME in manifest creation as docker meta tag is the full image name

@adrianchiris
Fix release workflow
5de2d3a 
- remove "latest" image tage from docker meta
- remove use of IMAGE_NAME in manifest creation as
  docker meta tag is the full image name

Signed-off-by: adrianc <[email protected]>
@adrianchiris adrianchiris requested a review from zeeke November 29, 2023 12:31
@adrianchiris
Copy link
Contributor Author

adrianchiris commented Nov 29, 2023 •
edited
Loading

Example run
https://github.com/adrianchiris/sriov-cni/actions/runs/7032568282/job/19136573250

zeeke
zeeke approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for looking at this

@zeeke zeeke merged commit 5615abc into k8snetworkplumbingwg:master Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeeke zeeke zeeke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrianchiris @zeeke