This repository was archived by the owner on Aug 22, 2022. It is now read-only.
[dnsmadeeasy-webhook][tt-rss][zalando-postgres-cluster] update to common-v3 #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelnu
requested review from
billimek,
bjw-s,
carpenike and
onedr0p
as code owners
angelnu
force-pushed
the
common-v3
branch
2 times, most recently
from
5b8f746 to
781ae0c
Compare
bjw-s
suggested changes
Jun 12, 2021
| @@ -77,7 +77,8 @@ dumpBackup: | |||
| memory: "10Mi" | |||
| cpu: "5m" | |||
|
|
|||
| # Dissable Deployment and Service | |||
| # Dissable Deployment and Service generation | |||
| controllerType: "" | |||
There was a problem hiding this comment.
controllerType is not a supported field.
There was a problem hiding this comment.
This one is a problem: the common v3 does not allow to run without controller. Will ping you to discuss a possible PR to add.
Co-authored-by: Bᴇʀɴᴅ Sᴄʜᴏʀɢᴇʀs <[email protected]>
Co-authored-by: Bᴇʀɴᴅ Sᴄʜᴏʀɢᴇʀs <[email protected]>
Co-authored-by: Bᴇʀɴᴅ Sᴄʜᴏʀɢᴇʀs <[email protected]>
Co-authored-by: Bᴇʀɴᴅ Sᴄʜᴏʀɢᴇʀs <[email protected]>
Co-authored-by: Bᴇʀɴᴅ Sᴄʜᴏʀɢᴇʀs <[email protected]>
Co-authored-by: Bᴇʀɴᴅ Sᴄʜᴏʀɢᴇʀs <[email protected]>
1 task
bjw-s
suggested changes
Jun 14, 2021
| controllerType: "" | ||
| # Disable Deployment | ||
| controller: | ||
| type: none |
There was a problem hiding this comment.
Suggested change
| type: none | |
| enabled: false |
bjw-s
reviewed
Jun 14, 2021
Comment on lines
80
to
87
| # Disable Deployment | ||
| controller: | ||
| enabled: false | ||
|
|
||
| # Disable Service | ||
| service: | ||
| main: | ||
| enabled: false |
There was a problem hiding this comment.
Do you not want to put these in as hardcoded in common.yaml?
There was a problem hiding this comment.
yes, I can do that in common.yaml
bjw-s
approved these changes
Jun 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Benefits
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver.[home-assistant])./hack/gen-helm-docs.sh stable <chart>)