Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compact rev sql on case of missing #395

Closed
wants to merge 1 commit into from

Conversation

mhmxs
Copy link
Contributor

@mhmxs mhmxs commented Jan 10, 2025

There is a very little chance that compactRevSQL is returning an empty result, which breaks other query executions. Coalesce ensures the query always returns a number.

@mhmxs mhmxs requested a review from a team as a code owner January 10, 2025 09:59
@brandond
Copy link
Member

There is some discussion about this at #374. The compact_rev_key row should never be absent. How are you able to reproduce this state? Even if you manually delete that row with sqlite CLI, it will be recreated on startup.

@mhmxs
Copy link
Contributor Author

mhmxs commented Jan 10, 2025

Thanks @brandond you are right, I forgot to start the driver and faced with the problem. So i made the fix. Weeks later i added the forgotten start for other reason, and didn't connect the dots it solves this issue. Sorry my bad :)

@mhmxs mhmxs closed this Jan 10, 2025
@mhmxs mhmxs deleted the fix-compact-rev-sql branch January 10, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants