fix: ratio rendering when no unit is present

jy95 · Apr 20, 2024 · 389327f · 389327f
1 parent 9ec6260
commit 389327f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/__tests__/fromDosageToText/rateRatio.test.tsx b/__tests__/fromDosageToText/rateRatio.test.tsx
@@ -102,6 +102,6 @@ describe("fromDosageToText - rateRatio", () => {
     };
 
     let result = dosageUtils.fromDosageToText(dosage);
-    expect(result).toBe("at a rate of 1 :128");
+    expect(result).toBe("at a rate of 1:128");
   });
 });
diff --git a/src/utils/fromRatioToString.ts b/src/utils/fromRatioToString.ts
@@ -34,8 +34,10 @@ export function fromRatioToString({
   let quantityNumerator = numerator?.value;
   let quantityDenominator = denominator?.value;
 
-  // Collect
+  // Collect results
   const parts: string[] = [];
+  let noUnits = numeratorUnit === undefined && denominatorUnit === undefined;
+  let separator = noUnits ? "" : " ";
 
   // Deal with numerator first
   if (quantityNumerator !== undefined) {
@@ -69,6 +71,6 @@ export function fromRatioToString({
   if (parts.length === 0) {
     return undefined;
   } else {
-    return parts.join(" ");
+    return parts.join(separator);
   }
 }