perf: remove useless double checks in PeriodPeriodMax (#49)

jy95 · Feb 1, 2025 · 2164cbb · 2164cbb
1 parent e100ca5
commit 2164cbb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/r4/src/main/java/io/github/jy95/fds/r4/translators/PeriodPeriodMaxR4.java b/r4/src/main/java/io/github/jy95/fds/r4/translators/PeriodPeriodMaxR4.java
@@ -55,7 +55,7 @@ public boolean hasPeriodMax(Dosage dosage) {
     @Override
     public boolean hasRequiredElements(Dosage dosage) {
         var timing = dosage.getTiming();
-        return timing.hasRepeat() && timing.hasRepeat() && (hasPeriod(dosage) || hasPeriodMax(dosage));
+        return timing.hasRepeat() && (hasPeriod(dosage) || hasPeriodMax(dosage));
     }
 
     /** {@inheritDoc} */

diff --git a/r5/src/main/java/io/github/jy95/fds/r5/translators/PeriodPeriodMaxR5.java b/r5/src/main/java/io/github/jy95/fds/r5/translators/PeriodPeriodMaxR5.java
@@ -55,7 +55,7 @@ public boolean hasPeriodMax(Dosage dosage) {
     @Override
     public boolean hasRequiredElements(Dosage dosage) {
         var timing = dosage.getTiming();
-        return timing.hasRepeat() && timing.hasRepeat() && (hasPeriod(dosage) || hasPeriodMax(dosage));
+        return timing.hasRepeat() && (hasPeriod(dosage) || hasPeriodMax(dosage));
     }
 
     /** {@inheritDoc} */