Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report failures on dashboard Fixes #18 #29

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Report failures on dashboard Fixes #18 #29

merged 2 commits into from
Feb 21, 2024

Conversation

jvivian
Copy link
Owner

@jvivian jvivian commented Feb 21, 2024

  • Add test to expand coverage for failures
  • Add failure reporting and explanation to dashboard
  • Decompose run_parameterized_model into simpler _run_model() subcall

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fixes #18
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0339eb8) 75.2% compared to head (0c695ed) 77.2%.

Files Patch % Lines
covid19_drdfm/dfm.py 92.8% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #29     +/-   ##
=======================================
+ Coverage   75.2%   77.2%   +1.9%     
=======================================
  Files          5       5             
  Lines        182     180      -2     
  Branches      35      34      -1     
=======================================
+ Hits         137     139      +2     
+ Misses        44      40      -4     
  Partials       1       1             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jvivian jvivian merged commit de6d868 into main Feb 21, 2024
6 of 7 checks passed
@jvivian jvivian deleted the jvivian/issue18 branch February 21, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant