Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shortcut editor not considering transient values #654

Merged
merged 1 commit into from
May 6, 2024

Conversation

jdpurcell
Copy link
Contributor

This PR fixed 2 issues with the shortcut editor dialog.

  1. Assuming all shortcuts are set to / saved with their default values, edit the "Show File Info" shortcut, changing it from "i" to "t". Click OK only on the "Modify Shortcuts" dialog, but do not click OK/Apply on the "Settings" dialog. Now try to edit the "Show in Finder/Explorer" shortcut, setting it to "i". You'll get an error saying "i" is already bound to "Show File Info", because the validation is only looking at the saved settings.
  2. Edit any shortcut, change the key binding to something else. Click OK only on the "Modify Shortcuts" dialog, but do not click OK/Apply on the "Settings" dialog. Now try to edit the same shortcut again. When the editor dialog appears, it still has the original/saved value, rather than the new changed value.

@jurplel jurplel merged commit ec7cac1 into jurplel:master May 6, 2024
6 checks passed
@jdpurcell jdpurcell deleted the transient-shortcuts branch June 29, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants