Localization for kernel-output example #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kgoo124 mind holding off on these until we implement #115, since we'll have to target them to the 3.0 branch? |
|
@blink1073 sure thing, sorry about that. just ping me when everything is set up! |
|
Will do! |
goanpeca
approved these changes
Sep 4, 2020
|
Thanks @kgoo124 @blink1073 @goanpeca for working on this. Would it be possible to update the PR to target the new |
|
@jtpio ready for merge |
thegooman
force-pushed
the
localization-kernel-output
branch
from
cccaca0 to
5923166
Compare
|
@jtpio ready for merge |
thegooman
force-pushed
the
localization-kernel-output
branch
3 times, most recently
from
66fd728 to
e021b8c
Compare
jtpio
force-pushed
the
localization-kernel-output
branch
from
e021b8c to
4136d50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #111