Don't remove URL parameters after loading #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to simply share the URL again, but may cause problems with overwriting if the page is reloaded. So perhaps this needs to be optional? Alternatively, we can make a fork specifically focused on jupyterlite only?
|
|
Hmm this might increase maintenance effort. Otherwise we could also introduce another query parameter to check whether to remove the |
|
@jtpio I think an additional query parameter makes sense to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to simply share the URL again, but may cause problems with overwriting if the page is reloaded. So perhaps this needs to be optional?
Alternatively, we can make a fork specifically focused on jupyterlite only?