Skip to content

Tidy up Headlines CSS #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 17, 2022
Merged

Tidy up Headlines CSS #662

merged 5 commits into from
Jan 17, 2022

Conversation

palewire
Copy link
Collaborator

@palewire palewire commented Jan 17, 2022

This fixes #650 by only styling the heading tags we actually use, and by replacing overly complex media queries with rem units.

It also includes a humble approach to #547 by adding the official brand font as the first option in the font-family setting. That means it will display if the user has it installed on their computer, but will otherwise fall back to the web fonts recommended by the brand guide.

@palewire palewire added this to the Streamline the site milestone Jan 17, 2022
@palewire palewire requested a review from choldgraf January 17, 2022 15:07
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me and the preview looks good!

@choldgraf choldgraf merged commit 0454922 into master Jan 17, 2022
@choldgraf choldgraf deleted the headlines branch January 17, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tidy up headline styles
2 participants