Skip to content

Conversation

@arjxn-py
Copy link
Contributor

Fix #522

@arjxn-py
Copy link
Contributor Author

cc: @JohanMabille @martinRenou

Is this how we want to use the xeus's routines?

@JohanMabille
Copy link
Member

These routines are meant to be used in the xinterpreter.cpp and xinterpreter-raw.cpp file. Except for create_successful_reply and create_error_reply that must be used in execute_request_impl, the other method names matches the request handler names.

We don't have the equivalent of these methods for the debugger (but it might be worth creating them in the future).

@arjxn-py arjxn-py marked this pull request as ready for review October 22, 2025 07:14
@arjxn-py
Copy link
Contributor Author

@martinRenou @JohanMabille This should be ready for your first review, please let me know if i am missing anything or overdid anything.

@arjxn-py arjxn-py requested a review from martinRenou October 22, 2025 13:16
@arjxn-py arjxn-py requested a review from martinRenou October 27, 2025 11:49
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit a91697a into jupyter-xeus:main Oct 28, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use xeus's routines for creating the replies

3 participants