Skip to content

Conversation

Yahiewi
Copy link
Collaborator

@Yahiewi Yahiewi commented Jul 25, 2025

This PR adds the following features:
-New Editor folder in the controls panel allows users to add joints by either toggling on the "Editor Mode" (could use a better name perhaps) and clicking on the parent and child links, or selecting them from a drop-down menu. The user can then input the parameters for the joint and add it. The added joint (if applicable) will appear in the joints folder and users can use it to move the robot.
-Input validation is now enforced on everything but the color selectors.
-Removed the need to refresh after adding a joint, it's now added immediately to the joints folder.

Copy link
Contributor

Binder 👈 Launch a Binder on branch Yahiewi/jupyterlab-urdf/joints

@IsabelParedes IsabelParedes added the enhancement New feature or request label Jul 25, 2025
Copy link
Member

@IsabelParedes IsabelParedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a bit of refactoring needed.

Copy link
Member

@IsabelParedes IsabelParedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing all the changes!

I tested it with URDFs which include mesh files and the Link Selector with the cursor was not able to select the links. Could you double check? Thanks!

@Yahiewi
Copy link
Collaborator Author

Yahiewi commented Aug 11, 2025

That is weird.
I just double checked and the Link Selector worked fine for all the files I tested on except for Panda where it worked but was a bit finicky (I'm guessing it might be because of the dae files).
I also checked that the version I tested on is the same one here (Tried pushing but everything was up to date).
Perhaps you can ignore this PR for now since you finished reviewing it and test the other PR instead which has all the changes added in this PR.

@IsabelParedes IsabelParedes merged commit db6ab29 into jupyter-robotics:main Aug 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants