Relocate Resource to org.junit.platform.commons.io package
#4891
+1,099
−172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport-candidate
theme: discovery
type: breaking change
labels
marcphilipp
force-pushed
the
marc/4876-resource-package
branch
from
7f4df46 to
ef9c80b
Compare
marcphilipp
commented
Sep 7, 2025
...form-commons/src/main/java/org/junit/platform/commons/support/scanning/ClasspathScanner.java
Show resolved
Hide resolved
marcphilipp
commented
Sep 7, 2025
junit-platform-engine/src/main/java/org/junit/platform/engine/discovery/DiscoverySelectors.java
Show resolved
Hide resolved
marcphilipp
changed the title
org.junit.platform.commons.io.ResourceResource to org.junit.platform.commons.io package
marcphilipp
force-pushed
the
marc/4876-resource-package
branch
from
4796abc to
9ec1c55
Compare
marcphilipp
commented
Sep 8, 2025
...form-commons/src/main/java/org/junit/platform/commons/support/scanning/ClasspathScanner.java
Show resolved
Hide resolved
marcphilipp
force-pushed
the
marc/4876-resource-package
branch
5 times, most recently
from
b0c6cc5 to
759a037
Compare
sormuras
approved these changes
Sep 9, 2025
marcphilipp
commented
Sep 12, 2025
junit-platform-commons/src/main/java/org/junit/platform/commons/io/DefaultResource.java
Show resolved
Hide resolved
marcphilipp
commented
Sep 12, 2025
...form-commons/src/main/java/org/junit/platform/commons/support/scanning/ClasspathScanner.java
Outdated
Show resolved
Hide resolved
marcphilipp
force-pushed
the
marc/4876-resource-package
branch
from
759a037 to
ebc6a85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
Resourceinterface in the neworg.junit.platform.commons.iopackage.The old interface extends the new one so it can be used in places that now consume the new interface.
The resource finding/scanning methods in
ReflectionSupportare now deprecated in favor of the new ones in theResourceSupportclass.Since
Predicate<...io.Resource>andPredicate<...support.Resource>have the same erasure, this PR introducesResourceFilter(mimicking the existingClassFilter) in order to be able to overload methods such asEngineDiscoveryRequestResolver.Builder.addResourceContainerSelectorResolver.Resolves #4885.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations