Support @Nullable reasons in ConditionEvaluationResult APIs
#4699
+133
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should decide if we want to backport any of the following to 5.13.x.
|
sbrannen
force-pushed
the
issues/4698-ConditionEvaluationResult-nullability
branch
from
d27adba to
8062b9f
Compare
marcphilipp
approved these changes
Jun 30, 2025
junit-jupiter-api/src/main/java/org/junit/jupiter/api/extension/ConditionEvaluationResult.java
Show resolved
Hide resolved
sbrannen
force-pushed
the
issues/4698-ConditionEvaluationResult-nullability
branch
from
8062b9f to
ae16e45
Compare
marcphilipp
reviewed
Jun 30, 2025
junit-jupiter-api/src/main/java/org/junit/jupiter/api/extension/ConditionEvaluationResult.java
Outdated
Show resolved
Hide resolved
I think we should backport all of them. |
In that case, I will create a separate GitHub issue to track all of that, since they are actually unrelated to the |
Closes junit-team#4698 Co-authored-by: Marc Philipp <[email protected]>
sbrannen
force-pushed
the
issues/4698-ConditionEvaluationResult-nullability
branch
from
b9b3c7e to
b206754
Compare
sbrannen
added a commit
that referenced
this pull request
Jun 30, 2025
Prior to this commit, we did not have any "unit tests" for ConditionEvaluationResult, and while working on #4698 I noticed that we in fact have several issues in the implementation of and documentation for ConditionEvaluationResult. Thus, this commit introduces dedicated unit tests for the status quo, where individual TODOs will be addressed in separate issues/commits. See #4698 See #4699 (comment)
marcphilipp
pushed a commit
that referenced
this pull request
Jul 1, 2025
Prior to this commit, we did not have any "unit tests" for ConditionEvaluationResult, and while working on #4698 I noticed that we in fact have several issues in the implementation of and documentation for ConditionEvaluationResult. Thus, this commit introduces dedicated unit tests for the status quo, where individual TODOs will be addressed in separate issues/commits. See #4698 See #4699 (comment) (cherry picked from commit 3026c62)
sbrannen
added a commit
that referenced
this pull request
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses the issues raised in #4698 by annotating all "reason" parameters with
@Nullable.Related Issues
ConditionEvaluationResultAPIs should accept@Nullablereasons #4698ConditionEvaluationResultreason values #4715