[Nonlinear] parse x*x as x^2 in Nonlinear.Model #2799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JuMP failure is because of #2775 |
|
It's an open question whether we should merge this. You might be tempted to say that this is an EAGO issue, not a JuMP/MOI issue. They should detect structure rather than relying on the precise way that JuMP users write models or MOI lowers a quadratic. |
|
I also think that they should probably detect the structure, the user may still be able to write |
blegat
approved these changes
Aug 7, 2025
|
Yeah there's no right or wrong answer here. Very much open for debate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue raised in PSORLab/EAGO.jl#150
I'll run
solver-teststo see if there's any impact.https://github.com/jump-dev/MathOptInterface.jl/actions/runs/16733837980