-
Notifications
You must be signed in to change notification settings - Fork 983
feat(projects): add optional description field to project model and API #1512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 4d4596b in 1 minute and 2 seconds. Click for details.
- Reviewed
161
lines of code in6
files - Skipped
0
files when reviewing. - Skipped posting
6
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. documentation/concepts/projects.mdx:29
- Draft comment:
Clarify that the top-level 'description' field is now separate from metadata. The sample payload correctly moves 'description' out of metadata, but a brief note might help avoid confusion. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
2. src/agents-api/agents_api/queries/projects/create_project.py:23
- Draft comment:
The INSERT query now includes the 'description' column with parameter $6. Confirm that 'data.description' may be None and is handled appropriately in downstream logic. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
3. src/agents-api/agents_api/queries/projects/list_projects.py:26
- Draft comment:
The SELECT query now returns the 'description' field to align with the updated model. This change looks consistent. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
4. src/memory-store/migrations/000044_add_project_description.down.sql:20
- Draft comment:
In the down migration, the default project function still injects a 'description' key into the metadata. Verify that this behavior aligns with the pre-migration implementation. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking the PR author to verify if the behavior aligns with the pre-migration implementation. This falls under asking the author to confirm their intention or to double-check things, which is against the rules.
5. src/memory-store/migrations/000044_add_project_description.up.sql:4
- Draft comment:
The migration up script correctly adds a 'description' column with a length constraint and updates the default project function accordingly. No issues found. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
6. src/typespec/projects/models.tsp:27
- Draft comment:
The Project model now includes an optional 'description' field, which aligns with the API changes. Looks good. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
Workflow ID: wflow_JhHo0TQi01EvvwBo
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
please review - @HamadaSalhab |
PR Type
Enhancement
resolves: #1465
Description
Add optional
description
field to project modelUpdate database schema with migration files
Modify API queries to handle new field
Update documentation with usage examples
Changes diagram
Changes walkthrough 📝
create_project.py
Update create project query for description
src/agents-api/agents_api/queries/projects/create_project.py
description
field to SQL INSERT querylist_projects.py
Include description in project listing
src/agents-api/agents_api/queries/projects/list_projects.py
description
field to SELECT querymodels.tsp
Add description to TypeSpec model
src/typespec/projects/models.tsp
projects.mdx
Document new description field
documentation/concepts/projects.mdx
000044_add_project_description.down.sql
Migration rollback for description field
src/memory-store/migrations/000044_add_project_description.down.sql
000044_add_project_description.up.sql
Database migration for description field
src/memory-store/migrations/000044_add_project_description.up.sql