add dim text modification #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanrgon
reviewed
Feb 23, 2021
terminology/ansi.py
Outdated
| @@ -183,9 +191,9 @@ def _remove_background_colors(text) -> StyledText: | |||
| return _remove_regex(BACKGROUND_COLORS_REGEX, text) | |||
|
|
|||
|
|
|||
| def _remove_bold(text) -> StyledText: | |||
| def _remove_bold_or_dim(text) -> StyledText: | |||
| """Remove all text modifications from the given text.""" | |||
There was a problem hiding this comment.
This is unrelated to your change, but this docstring is 100% incorrect. Are you willing to update it to
Suggested change
| """Remove all text modifications from the given text.""" | |
| """Remove bold and dim modifications from the text.""" |
juanrgon
reviewed
Feb 23, 2021
Comment on lines
+158
to
+160
| def dimmed(self) -> "StyledText": | ||
| return dimmed(self) | ||
|
|
There was a problem hiding this comment.
So, it may seem trivial, but I try to keep my methods and functions alphabetized when there is a lot of them like there are here. There are ways to enforce that, but I haven't set that up. Would you be up for moving dimmed to the top
juanrgon
reviewed
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.