Skip to content

Remote repositories #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remote repositories #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bffa5bf
Minor refactoring and cleanup
pgier May 21, 2013
afe5f84
Use repository settings from the current build for downloading remote…
pgier May 22, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 59 additions & 27 deletions src/main/java/org/jboss/maven/extension/dependency/resolver/EffectiveModelBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import java.util.List;
import java.util.Map;

import org.apache.maven.artifact.repository.ArtifactRepository;
import org.apache.maven.execution.MavenSession;
import org.apache.maven.model.Model;
import org.apache.maven.model.Plugin;
Expand Down Expand Up @@ -69,18 +70,49 @@ public class EffectiveModelBuilder

private ModelBuilder modelBuilder;

/**
* Repositories for downloading remote poms
*/
private List<RemoteRepository> repositories;

public List<RemoteRepository> getRepositories()
/**
* Get list of remote repositories from which to download artifacts
*
* @return list of repositories
*/
private List<RemoteRepository> getRepositories()
{
if ( repositories == null )
{
repositories = new ArrayList<RemoteRepository>();
}

return repositories;
}

/**
* Set the list of remote repositories from which to download
* dependency management poms.
*
* @param repositories
*/
public void setRepositories( List<RemoteRepository> repositories )
{
this.repositories = repositories;
}

/**
* Set the list of remote repositories from which to download
* dependency management poms.
*
* @param repositories
*/
public void addRepository( ArtifactRepository repository )
{
RemoteRepository remoteRepo = new RemoteRepository(repository.getId(), "default", repository.getUrl());
getRepositories().add( remoteRepo );
}

/**
* Private constructor for singleton
*/
Expand All @@ -97,6 +129,25 @@ public static void init( MavenSession session, ArtifactResolver resolver, ModelB
instance.repositorySystem = newRepositorySystem();
instance.resolver = resolver;
instance.modelBuilder = modelBuilder;
initRepositories(session.getRequest().getRemoteRepositories());
}

/**
* Initialize the set of repositories from which to download remote artifacts
* @param repositories
*/
private static void initRepositories(List<ArtifactRepository> repositories)
{
if (repositories == null || repositories.size() == 0)
{
// Set default repository list to include Maven central
String remoteRepoUrl = "http://repo.maven.apache.org/maven2";
instance.getRepositories().add( new RemoteRepository( "central", "default", remoteRepoUrl ) );
}
for (ArtifactRepository artifactRepository : repositories)
{
instance.addRepository( artifactRepository );
}
}

/**
Expand All @@ -114,19 +165,19 @@ public Map<String, String> getRemoteDependencyVersionOverrides( String gav )
{
Map<String, String> versionOverrides = new HashMap<String, String>();

System.out.println( "resolving gav: " + gav );
logger.debug( "resolving gav: " + gav );
Artifact artifact = resolvePom( gav );

ModelResolver modelResolver = this.newModelResolver();

Model effectiveModel = buildModel( artifact.getFile(), modelResolver );
System.out.println( "Built model for project: " + effectiveModel.getName() );
logger.debug( "Built model for project: " + effectiveModel.getName() );

for ( org.apache.maven.model.Dependency dep : effectiveModel.getDependencyManagement().getDependencies() )
{
String groupIdArtifactId = dep.getGroupId() + ":" + dep.getArtifactId();
versionOverrides.put( groupIdArtifactId, dep.getVersion() );
System.out.println( "Added version override for: " + groupIdArtifactId + ":" + dep.getVersion() );
logger.debug( "Added version override for: " + groupIdArtifactId + ":" + dep.getVersion() );
}

return versionOverrides;
Expand Down Expand Up @@ -187,38 +238,19 @@ public ArtifactDescriptorResult resolveRemoteArtifactDescriptor( String gav )

ArtifactDescriptorRequest descRequest = new ArtifactDescriptorRequest();
descRequest.setArtifact( artifact );
descRequest.setRepositories( getRemoteRepositories() );
descRequest.setRepositories( getRepositories() );

ArtifactDescriptorResult descResult = repositorySystem.readArtifactDescriptor( repoSession, descRequest );
for ( Dependency dep : descResult.getManagedDependencies() )
{
logger.info( "Remote managed dep: " + dep );
}

System.out.println( artifact + " resolved to " + artifact.getFile() );
logger.debug( artifact + " resolved to " + artifact.getFile() );

return descResult;
}

/**
* Get list of remote repositories from which to download artifacts
*
* @return list of repositories
*/
private List<RemoteRepository> getRemoteRepositories()
{
if ( repositories == null )
{
// Set default repository list to include Maven central
repositories = new ArrayList<RemoteRepository>();

String remoteRepoUrl = "http://repo1.maven.org/maven2/";
repositories.add( new RemoteRepository( "central", "default", remoteRepoUrl ) );
}

return repositories;
}

/**
* Build the effective model for the given pom file
*
Expand Down Expand Up @@ -286,7 +318,7 @@ private Artifact resolveArtifact( Artifact artifact )
{
ArtifactRequest request = new ArtifactRequest();
request.setArtifact( artifact );
request.setRepositories( getRemoteRepositories() );
request.setRepositories( getRepositories() );

RepositorySystemSession repositorySession = session.getRepositorySession();
ArtifactResult result = resolver.resolveArtifact( repositorySession, request );
Expand All @@ -297,7 +329,7 @@ private ModelResolver newModelResolver()
{
RemoteRepositoryManager repoMgr = new DefaultRemoteRepositoryManager();
ModelResolver modelResolver =
new BasicModelResolver( session.getRepositorySession(), resolver, repoMgr, getRemoteRepositories() );
new BasicModelResolver( session.getRepositorySession(), resolver, repoMgr, getRepositories() );

return modelResolver;
}
Expand Down