-
-
Notifications
You must be signed in to change notification settings - Fork 252
adding bootstrap-datepicker #204
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line isn't necessary - rather add css as a dependency of the package to download - https://github.com/jspm/registry/blob/master/package-overrides/github/twbs/bootstrap%403.1.0.json#L5. Also is Bootstrap itself a dependency?
|
Thanks! |
|
Hi, they updated their project to match "map": {
"jquery": "@empty"
},Because it brings But, importing a specific locale cause issue for me, I'm not able to make this works. import 'bootstrap-datepicker';
import 'bootstrap-datepicker/dist/locales/bootstrap-datepicker.fr.min';When I bundle (SFX) my app it seems that the I tried to add in my "meta": {
"bootstrap-datepicker/dist/locales/bootstrap-datepicker.fr.min": {
"deps": [
"bootstrap-datepicker"
]
},
}It does not fix the issue. Any help or tips would be really appreciated. May relates to uxsolutions/bootstrap-datepicker#1781 and jspm/jspm#1294 Edit: I finally manage to make it works!! I had to add a "npm:[email protected]": {
"map": {
"jquery": "jquery"
},
"shim": {
"dist/locales/*": {
"deps": [
"bootstrap-datepicker"
]
}
}
} |
|
@cAhmad if you're able to share the above override with a new PR that would be great. Also the |
|
Just submitted the PR. |
|
Great thanks for coming back to this. |
No description provided.