Skip to content

Modify parsers to be AST-based #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 40 commits into
base: main
Choose a base branch
from
Draft

Modify parsers to be AST-based #239

wants to merge 40 commits into from

Conversation

asamuzaK
Copy link
Contributor

@asamuzaK asamuzaK commented Jul 30, 2025 •
edited
Loading

@asamuzaK asamuzaK marked this pull request as draft July 30, 2025 20:56
@asamuzaK asamuzaK force-pushed the valid branch 4 times, most recently from 96f666d to e75e388 Compare August 2, 2025 07:05
@asamuzaK asamuzaK changed the title Replace isValid() with isValidPropertyValue() Use cssTree features whenever possible Aug 2, 2025
@asamuzaK asamuzaK changed the title Use cssTree features wherever possible Modify parsers to be AST-based Aug 3, 2025
@asamuzaK asamuzaK marked this pull request as draft August 3, 2025 08:15
@asamuzaK asamuzaK force-pushed the valid branch 2 times, most recently from 4b0abbe to 66a94b6 Compare August 4, 2025 23:54
@asamuzaK
Copy link
Contributor Author

asamuzaK commented Aug 15, 2025 •
edited
Loading

TODO:

  • Rewrite parsers.test.js to accept arrays as arguments
  • After that, for the parseFoo function in parsers.js, remove the process of accepting a string as an argument.
  • Fix rest of the shorthand issues.

@asamuzaK asamuzaK force-pushed the valid branch 3 times, most recently from 815dd86 to ae88254 Compare August 18, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite parsers to be AST based Replace isValid() with isValidPropertyValue() Use @webref/css
1 participant
@asamuzaK