Skip to content

fix(recording): save recording when captured window closes#89

Merged
jsattler merged 1 commit intojsattler:mainfrom
ignacio-sj:main
Feb 12, 2026
Merged

fix(recording): save recording when captured window closes#89
jsattler merged 1 commit intojsattler:mainfrom
ignacio-sj:main

Conversation

@ignacio-sj
Copy link
Contributor

@ignacio-sj ignacio-sj commented Feb 12, 2026

Summary

  • When recording a window that gets closed, the app now attempts to save the recording instead of discarding it
  • Previously, any non-.userStopped stream error during recording would call assetWriter.cancel(), losing all captured data
  • Now both code paths (user stop sharing + unexpected stream stop) call stopRecording(), which finalizes the file gracefully and falls back to cancel if finalization fails

Test plan

  • Start recording a specific window
  • Close that window while recording is active
  • Verify the recording is saved to the output folder
  • Verify the saved file is playable in QuickTime

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jsattler
Copy link
Owner

Thanks for fixing!

@jsattler jsattler merged commit 1237c29 into jsattler:main Feb 12, 2026
2 checks passed
@jsattler jsattler added the bug Something isn't working label Feb 12, 2026
@jsattler jsattler added this to the 2026.2 milestone Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments