Restore previous work on concatenated gzip streams #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code here as-is broke two JRuby tests: ``` 1) Failure: TestZlibGzipFile#test_gzip_reader_zcat [/home/runner/work/jruby/jruby/test/mri/zlib/test_zlib.rb:594]: <["foo", "bar"]> expected but was <["foobar"]>. 2) Failure: TestZlibGzipReader#test_unused2 [/home/runner/work/jruby/jruby/test/mri/zlib/test_zlib.rb:960]: <"aaaa"> expected but was <"aaaabbbb">. ``` I reverted it for 1.1.5 but preserve the work here. See ymnk/jzlib@0c1c243 for the original branch by @ymnk.
headius
added a commit
to headius/jruby
that referenced
this pull request
May 25, 2023
The concatenated gzip stream work in jruby/jzlib#1 broke some tests. We'll revisit it later.
headius
added a commit
to headius/jruby
that referenced
this pull request
May 25, 2023
The concatenated gzip stream work in jruby/jzlib#1 broke some tests. We'll revisit it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code here as-is broke two JRuby tests:
I reverted it for 1.1.5 but preserve the work here.
See ymnk/jzlib@0c1c243 for the original branch by @ymnk.