Make JRuby version checking more robust #142
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use actual JRuby version so we don't have to update these tests.
This modifies the handling of the `jruby -v` output to specifically search for the line starting with `jruby`, avoiding other lines such as those that might be output by the JDK for the env var JDK_JAVA_OPTIONS. Fixes jruby#140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two changes:
jruby -vparsing to look for the line starting withjruby, avoiding other logging output from JRuby or the underlying JDK (download gems, and then threw an error #140).This will fix #140, but I was unable to reproduce the original issue even unpatched.