Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2A2A1-LEFT_LIP_MODULE.ino #119

Merged
merged 1 commit into from
Mar 22, 2025
Merged

Conversation

Arribe
Copy link
Collaborator

@Arribe Arribe commented Feb 11, 2025

Description

A Hornet's Nest reported a bug with the IFEI Brightness knob, with fix on his EP:26 IFEI video. This commit incorporates the fix to redefining the pin to A9 to fix the analog read.

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Closes #

Dependencies

  • List any dependencies that are required for this change, including a full list of libraries required, especially if it is a new or otherwise unused library in the OpenHornet software.

Type of change

  • New software module (new software module for slave)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update outside of the automatically-generated Doxygen documentation.

Checklist:

  • My code follows the style guidelines of this project
  • I have complied with the software manual for this project
  • I have performed a self-review of my own code
  • I have commented my code fully with Doxygen compatible comments, particularly in hard-to-understand areas
  • I have made corresponding changes to non-Doxygen generated documentation
  • I have ran Doxygen locally, and it builds the docs successfully
  • My changes generate no errors on compile in Arduino IDE
  • My changes generate no new warnings on compile in Arduino IDE
  • Any dependent changes have been merged and published in downstream modules
  • (For sketches only) This sketch complies with OH-INTERCONNECT v****
  • If this sketch requires additional libraries, I have added it as a sub-module per the Arduino Libraries section of the Software Manual.

How Has This Been Tested?

  • I have tested the sketch in-circuit in DCS with DCS-BIOS and outputs (displays, LEDs, etc.) function as expected.
  • I have tested the sketch in-circuit in DCS with DCS-BIOS and HID inputs (switches, pots, etc.) function as expected, with switches moving the correct direction.
  • I have tested the sketch in-circuit in DCS with DCS-BIOS and any logic in the sketch has been tested and functions as expected.
  • This code has not yet been tested in-circuit.
  • This code has not yet been tested in DCS-BIOS.

Description of Testing

Watched A Hornet's Nest EP:26 video.

Test Configuration

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

A Hornet's Nest reported a bug with the IFEI Brightness knob, with fix on his video IFEI part 2 video.  This commit incorporates the fix to redefining the pin to A9 to fix the analog read.
@jrsteensen jrsteensen self-requested a review March 22, 2025 22:15
@jrsteensen jrsteensen added Type: Bug Something is not working as expected. Category: Embedded This issue affects a specific embedded microcontroller software (i.e. an Arduino Sketch). P2 High Priority: This is the defect or issue which should be resolved before the release is made. Thes S3 Moderate Severity: Any feature implemented that is not meeting its requirements/use case(s) and beha labels Mar 22, 2025
@jrsteensen jrsteensen added this to the v0.1.0 milestone Mar 22, 2025
Copy link
Owner

@jrsteensen jrsteensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Arribe for the PR!

@jrsteensen jrsteensen merged commit 0b7d36b into jrsteensen:develop Mar 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Embedded This issue affects a specific embedded microcontroller software (i.e. an Arduino Sketch). P2 High Priority: This is the defect or issue which should be resolved before the release is made. Thes S3 Moderate Severity: Any feature implemented that is not meeting its requirements/use case(s) and beha Type: Bug Something is not working as expected.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants