Skip to content

check for a blank caption line #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

check for a blank caption line #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2f1256
check for a blank caption line
schacon Jul 28, 2015
14b8b3b
just shift the array instead
schacon Jul 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/webvtt/file.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,12 @@ def add_a_cue(collected_lines)
cue_opts = {}
if collected_lines.first.include?('-->')
cue_opts[:identifier] = nil
cue_opts[:cue_line] = collected_lines.first
cue_opts[:cue_line] = collected_lines.shift
elsif collected_lines[1].include?('-->')
cue_opts[:identifier] = collected_lines.first
cue_opts[:cue_line] = collected_lines[1]
cue_opts[:identifier] = collected_lines.shift
cue_opts[:cue_line] = collected_lines.shift
end
cue_opts[:text] = collected_lines[2..-1].join("\n")
cue_opts[:text] = collected_lines.join(' ')
cues << Cue.new(cue_opts)
end

Expand Down