Skip to content

Change sourcekitd_* functions to public #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

norio-nomura
Copy link
Collaborator

Fix #487

@norio-nomura
Copy link
Collaborator Author

Closing since #487 was closed.
I think that it is not good that there is no function to create sourcekitd_object_t which Request.customRequest needs.

@ileitch
Copy link
Contributor

ileitch commented Feb 7, 2018

Oh, I thought this change was still valid. For example you can create a sourcekitd_object_t from sourcekitd_request_dictionary_create, e.g Request.customRequest(request: sourcekitd_request_dictionary_create(&keys, &values, dict.count)!).send().

Without this PR it makes little sense for customRequest to be public, I don't see any other way to use it?

@norio-nomura norio-nomura reopened this Feb 7, 2018
@norio-nomura
Copy link
Collaborator Author

Sorry, reopened.

@norio-nomura
Copy link
Collaborator Author

As a personal opinion, I would like to recommend #490 than this.

@jpsim
Copy link
Owner

jpsim commented Feb 8, 2018

Agreed, let's pursue #490 over this. Thanks for leading the charge, @norio-nomura.

@jpsim jpsim closed this Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants