Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new color variable #93

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+16 −5
Open

Added new color variable #93

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5b9baf5
Added new color variable
NecrCode Oct 22, 2022
1d6688c
Update doxygen-awesome.css
NecrCode Oct 22, 2022
ec2c534
Colored Paramaters in description
NecrCode Oct 22, 2022
b9f7c7c
Update doxygen-awesome.css
NecrCode Jan 4, 2023
e747a63
adjusting mdescLeft/Right and memItemLeft/Right border radius
NecrCode Dec 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions doxygen-awesome.css
View file
Original file line number Diff line number Diff line change
@@ -150,6 +150,7 @@ html {
--fragment-linenumber-background: #f4f4f5;
--fragment-linenumber-border: #e3e5e7;
--fragment-lineheight: 20px;
--fragment-desc-background: #f4f4f4;

/* sidebar navigation (treeview) colors */
--side-nav-background: #fbfbfb;
@@ -186,7 +187,7 @@ html {
color-scheme: dark;

--primary-color: #1982d2;
--primary-dark-color: #86a9c4;
--primary-dark-color: #ddb582;
Comment on lines -189 to +190
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new colors that you choose for WxWidgets look great IMO! I'd like to keep the original colors as default though, for both variables, --primary-dark-color and --fragment-desc-background.

--primary-light-color: #4779ac;

--box-shadow: 0 2px 8px 0 rgba(0,0,0,.35);
@@ -239,6 +240,7 @@ html {
--fragment-linenumber-color: #cccccc;
--fragment-linenumber-background: #35393c;
--fragment-linenumber-border: #1f1f1f;
--fragment-desc-background: #2e343e;
}
}

@@ -247,7 +249,7 @@ html.dark-mode {
color-scheme: dark;

--primary-color: #1982d2;
--primary-dark-color: #86a9c4;
--primary-dark-color: #ddb582;
--primary-light-color: #4779ac;

--box-shadow: 0 2px 8px 0 rgba(0,0,0,.30);
@@ -300,6 +302,7 @@ html.dark-mode {
--fragment-linenumber-color: #cccccc;
--fragment-linenumber-background: #35393c;
--fragment-linenumber-border: #1f1f1f;
--fragment-desc-background: #2e343e;
}

body {
@@ -1031,7 +1034,7 @@ blockquote::after {
blockquote p {
margin: var(--spacing-small) 0 var(--spacing-medium) 0;
}
.paramname {
.paramname, div.memdoc em {
font-weight: 600;
color: var(--primary-dark-color);
}
@@ -1415,7 +1418,8 @@ div.memdoc, div.memproto, h2.memtitle {

div.memdoc {
padding: 0 var(--spacing-medium);
background: var(--page-background-color);
overflow: auto;
background: var(--fragment-desc-background);
}

h2.memtitle, div.memitem {
@@ -1791,11 +1795,18 @@ table.memberdecls .memItemRight {
}

table.memberdecls .mdescLeft, table.memberdecls .mdescRight {
background: none;
background: var(--fragment-desc-background);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a problem with this. It doesn't work well with the current design of the member overview. The block above has rounded corners and creates a small gap, which doesn't look nice IMO:

I'd like the background coloring of the brief description to be an option that can be enabled, but I'm not sure how this could be implemented atm. :/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be solved by removing border-right/left-radius for both .memItem left & right respectively,
also i'm not sure about border color (bottom) should it be left as it is, or removed too and added to mdesc's bottom as shown here:
image

or should it be just like this, no borders at all:
image

what do you think? ( and i truly appreciate the detailed feedback, thanks :) !)

color: var(--page-foreground-color);
padding: var(--spacing-small) 0;
}

table.memberdecls .mdescLeft{
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, the small gap is no longer there, i was going to remove bottom border for memItemL/R, but it would look a bit weird when there's no mdescL/R, so that's why i left it as is.

border-radius: 0 0 0 var(--border-radius-small);
}
table.memberdecls .mdescRight {
border-radius: 0 0 var(--border-radius-small) 0;
}

table.memberdecls .memItemLeft,
table.memberdecls .memTemplItemLeft {
padding-right: var(--spacing-medium);