WIP feat: implement gamma function for general BigNumber #3583
+180
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, gamma on BigNumbers only worked for positive integers. This change implements a general arbitrary-precision algorithm based on the Stirling series (reference included in the code), and adds tests for it. This PR is the last stepping stone needed to correct the computation of zeta(n), resolving further bugs found based on #3532.
It is only a work-in-progress because ultimately the implementation needs to compute factorials, rising factorials, and double factorials. As submitted, the code uses inefficient temporary code for the variant factorials so that the algorithm could be implemented and tested. However, once #3568 or an agreeable substitute is merged, calls to whatever the resulting facility is for all forms of factorial needs to be inserted, and the computation of the ordinary factorial needs to be moved into factorial.js and then called from gamma, rather than the current roundabout organization where the code for factorial resides in gamma, but calling factorial forwards to gamma.