Skip to content

Commit

Permalink
Merge pull request #36 from jordanopensource/task/update_whoami-chart
Browse files Browse the repository at this point in the history
Add configmap file to whoami chart
  • Loading branch information
thread-koder authored Sep 18, 2023
2 parents 4700ba4 + d153df0 commit be68b96
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
2 changes: 1 addition & 1 deletion charts/whoami/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ maintainers:
- email: [email protected]
name: Jordan Open Source Association
name: whoami
version: 1.2.0
version: 1.2.1
icon: https://raw.githubusercontent.com/stackrox/kube-linter/main/images/logo/KubeLinter-vertical.svg
4 changes: 1 addition & 3 deletions charts/whoami/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,8 @@ spec:
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
envFrom:
{{ range .Values.extraEnvFromConfigMap }}
- configMapRef:
name: {{ . }}
{{ end }}
name: {{ .Values.extraEnvFromConfigMap }}
ports:
- name: http
containerPort: 80
Expand Down
3 changes: 1 addition & 2 deletions charts/whoami/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ ingress:
# - secretName: chart-example-tls
# hosts:
# - chart-example.local
extraEnvFromConfigMap:
[]
extraEnvFromConfigMap: ''
resources: {}
# We usually recommend not to specify default resources and to leave this as a conscious
# choice for the user. This also increases chances charts run on environments with little
Expand Down

0 comments on commit be68b96

Please sign in to comment.