replaces scss with rendered css #33
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, it looks like it was scss file with css extension. But why you decide to remove source scss file? |
|
I figured that it would be the best solution since SCSS is not listed as a dependency. |
|
I would prefer to leave it as scss and add sass-rails as a dependency. It would reduce the complexity of maintaining the project, and reduce the possibility of versions getting out of whack. |
|
makes sense. Wasn't sure if you wanted to add a dependency. #34 it is then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested this locally. My app's datepicker works as expected. Used an SCSS to CSS parser from SassMeister.