[6.1] Batch Copy & Move tags #46501
Open
[6.1] Batch Copy & Move tags #46501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
Language Change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a recreation of #41927, where I accidentally deleted all the code changes.
Pull Request for Issue #23304, only partially.
This PR is based on #38583 and fixes the comments.
Summary of Changes
Adds the ability to batch copy/move tags in the tags list.
Copying a tag also copies its children (same behavior as in other tree models like categories, menues).
Moving a tag also moves its children (same behavior as in other tree models like categories, menues).
For example, it is possible to move a child tag from one parent to another (including its children), or to copy a child tag from one parent to another (including its children).
In the batch tag drop down there is also an item "Root" to move/copy selected tags to the root level.
Changed visualization "Action to Perform" of copy/move action, it is now hidden as long as the user does not touch the select field for copy/move. See example in video below. This change affects batch copy/move dialog of menues and articles as well.
It also fixes a browser console error when the batch dialog is opened and cancel is clicked, on systems where multilingual is disabled.
Testing Instructions
It contains an updated javascript so run: npm run build:js
Initial tag structure for each of the tests below:
Tag1
-Tag2
--Tag3
Tag4
Test 1
Move Tag2 to Tag4 results in:
Tag1
Tag4
-Tag2
--Tag3
Test 2
Move Tag1 to Tag4 results in:
Tag4
-Tag1
--Tag2
---Tag3
Test 3
Copy Tag4 to Tag2 result in:
Tag1
-Tag2
--Tag3
--Tag4 (2)
Tag4
Test 4
Check whether the visualization of "Action to Perform" of copy/move action is first hidden for views like menues, articles. Only if a target item is selected "Action to Perform" appears.
Actual result BEFORE applying this Pull Request
The tags list batch processing does not support copy move.
Expected result AFTER applying this Pull Request
The tags list batch processing supports copy move:
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed