Skip to content

Conversation

brianteeman
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

Include the name of the extension in the successful uninstall message. This is particularly useful when you uninstall multiple extensions at the same time.

Testing Instructions

Uninstall one or more extensions

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-6.1-dev labels Oct 13, 2025
@brianteeman
Copy link
Contributor Author

The failing system test is expected. I can fix it if there is interest in this PR

@richard67
Copy link
Member

The failing system test is expected. I can fix it if there is interest in this PR

@brianteeman Ir fails at the "can install and uninstall a component from URL tab" test in file tests/System/integration/administrator/components/com_installer/FromUrl.cy because of the changed language string, so fixing it in this PR would be welcome.

@brianteeman
Copy link
Contributor Author

Yes I know why it fails and if this pr has any interest I will fix it

@brianteeman
Copy link
Contributor Author

It's been uninstalled so the language string no longer exists

@Fedik
Copy link
Member

Fedik commented Oct 14, 2025

No it is not. It is uninstalled at line 261. Before that it should be possible tor translate, in theory.
However when language files are not loaded you can ignore that suggestion. I cannot check it currently.

@brianteeman
Copy link
Contributor Author

If you can get it to work then please submit a pr to this branch. I tried and can not

@Fedik
Copy link
Member

Fedik commented Oct 14, 2025

Okay I checked and it is possible to translate, but it need much more work. Can ignore that suggestion.

But please update UNINSTALL_ERROR message.
You can trigger it by removing the line 261

$result = $installer->uninstall($row->type, $id);

@brianteeman
Copy link
Contributor Author

brianteeman commented Oct 14, 2025

added the name to the uninstall error message

@Fedik
Copy link
Member

Fedik commented Oct 14, 2025

I have tested this item ✅ successfully on 1bc07de


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46277.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants