-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[6.1] Meaningful uninstall message #46277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 6.1-dev
Are you sure you want to change the base?
Conversation
The failing system test is expected. I can fix it if there is interest in this PR |
@brianteeman Ir fails at the "can install and uninstall a component from URL tab" test in file |
Yes I know why it fails and if this pr has any interest I will fix it |
administrator/components/com_installer/src/Model/ManageModel.php
Outdated
Show resolved
Hide resolved
It's been uninstalled so the language string no longer exists |
No it is not. It is uninstalled at line 261. Before that it should be possible tor translate, in theory. |
If you can get it to work then please submit a pr to this branch. I tried and can not |
Okay I checked and it is possible to translate, but it need much more work. Can ignore that suggestion. But please update UNINSTALL_ERROR message.
|
added the name to the uninstall error message |
I have tested this item ✅ successfully on 1bc07de This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46277. |
Pull Request for Issue # .
Summary of Changes
Include the name of the extension in the successful uninstall message. This is particularly useful when you uninstall multiple extensions at the same time.
Testing Instructions
Uninstall one or more extensions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed