Skip to content

[5.4] hide container automated updates when install additional languages #46275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 5.4-dev
Choose a base branch
from
Open

[5.4] hide container automated updates when install additional languages #46275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
872e881
apply autoformat (vscode)
heelc29 Oct 12, 2025
08a071f
[5.4] hide container automated updates when install additional language
heelc29 Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
215 changes: 110 additions & 105 deletions installation/template/js/remove.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,38 +7,43 @@
var url = Joomla.getOptions('system.installation').url ? Joomla.getOptions('system.installation').url.replace(/&/g, '&') : 'index.php';

if (document.getElementById('installAddFeatures')) {
document.getElementById('installAddFeatures').addEventListener('click', function(e) {
document.getElementById('installAddFeatures').addEventListener('click', function (e) {
e.preventDefault();
document.getElementById('installLanguages').classList.add('active');
document.getElementById('installCongrat').classList.remove('active');
document.getElementById('installFinal').classList.remove('active');
document.getElementById('installRecommended').classList.remove('active');
if (document.getElementById('automatedUpdates')) {
document.getElementById('automatedUpdates').classList.remove('active');
}
})
}

if (document.getElementById('skipLanguages')) {
document.getElementById('skipLanguages').addEventListener('click', function(e) {
e.preventDefault();
document.getElementById('installCongrat').classList.add('active');
document.getElementById('installFinal').classList.add('active');
document.getElementById('installRecommended').classList.add('active');
document.getElementById('installLanguages').classList.remove('active');

if (document.getElementById('installFinal')) {
document.getElementById('installFinal').focus();
}
})
document.getElementById('skipLanguages').addEventListener('click', function (e) {
e.preventDefault();
document.getElementById('installCongrat').classList.add('active');
document.getElementById('installFinal').classList.add('active');
document.getElementById('installRecommended').classList.add('active');
document.getElementById('installLanguages').classList.remove('active');
if (document.getElementById('automatedUpdates')) {
document.getElementById('automatedUpdates').classList.add('active');
}

if (document.getElementById('installFinal')) {
document.getElementById('installFinal').focus();
}
})
}

if (document.getElementById('removeInstallationFolder')) {
document.getElementById('removeInstallationFolder')
.addEventListener('click', function (e) {
e.preventDefault();
let confirm = window.confirm(Joomla.Text._('INSTL_REMOVE_INST_FOLDER').replace('%s', 'installation'));
if (confirm) {
Joomla.deleteJoomlaInstallationDirectory();
}
});
document.getElementById('removeInstallationFolder').addEventListener('click', function (e) {
e.preventDefault();
let confirm = window.confirm(Joomla.Text._('INSTL_REMOVE_INST_FOLDER').replace('%s', 'installation'));
if (confirm) {
Joomla.deleteJoomlaInstallationDirectory();
}
});
}

if (document.getElementById('automatedUpdatesDisableButton')) {
Expand All @@ -54,20 +59,20 @@ if (document.getElementById('automatedUpdatesDisableButton')) {

const completeInstallationOptions = document.querySelectorAll('.complete-installation');

completeInstallationOptions.forEach(function(item) {
item.addEventListener('click', function (e) {
// In development mode we show the user a pretty button to allow them to choose whether to delete the installation
// directory or not. In this case or when the installation folder has been deleted or might be partly deleted,
// the buttons just redirect to the admin or site.
// In stable release we always try to delete the folder at the first click. Maximum extermination!
if ('development' in item.dataset || 'installremoved' in item.dataset) {
window.location.href = item.dataset.href;
} else {
Joomla.deleteJoomlaInstallationDirectory(item.dataset.href);
}
completeInstallationOptions.forEach(function (item) {
item.addEventListener('click', function (e) {
// In development mode we show the user a pretty button to allow them to choose whether to delete the installation
// directory or not. In this case or when the installation folder has been deleted or might be partly deleted,
// the buttons just redirect to the admin or site.
// In stable release we always try to delete the folder at the first click. Maximum extermination!
if ('development' in item.dataset || 'installremoved' in item.dataset) {
window.location.href = item.dataset.href;
} else {
Joomla.deleteJoomlaInstallationDirectory(item.dataset.href);
}

return false;
});
return false;
});
});


Expand All @@ -83,10 +88,10 @@ Joomla.disableAutomatedUpdates = function () {
if (successresponse.error === true) {
if (successresponse.messages) {
Joomla.renderMessages(successresponse.messages);
Joomla.loadOptions({'csrf.token': successresponse.token});
Joomla.loadOptions({ 'csrf.token': successresponse.token });
} else {
// Stuff went wrong. No error messages. Just panic bail!
Joomla.renderMessages({error:['Unknown error disabling the automated updates.']});
Joomla.renderMessages({ error: ['Unknown error disabling the automated updates.'] });
}
} else {
const automatedUpdates = document.getElementById('automatedUpdates');
Expand All @@ -100,79 +105,79 @@ Joomla.disableAutomatedUpdates = function () {
}

Joomla.deleteJoomlaInstallationDirectory = function (redirectUrl) {
Joomla.request({
method: "POST",
url: Joomla.installationBaseUrl + '?task=installation.removeFolder&format=json',
perform: true,
token: true,
headers: { 'Content-Type': 'application/x-www-form-urlencoded' },
onSuccess: function (response) {
// If the installation folder has been deleted at least partly, i.e. also
// in case of a failure, we cannot use it anymore.
// Therefore set a marker in the admin and site buttons so they still work
// and disable buttons which will not work anymore.
completeInstallationOptions.forEach(function(item) {
item.dataset.installremoved = 'true';
});
if (document.getElementById('installAddFeatures')) {
document.getElementById('installAddFeatures').disabled = true;
}
if (document.getElementById('automatedUpdatesDisableButton')) {
document.getElementById('automatedUpdatesDisableButton').disabled = true;
}
if (document.getElementById('removeInstallationFolder')) {
document.getElementById('removeInstallationFolder').disabled = true;
}
const successresponse = JSON.parse(response);
if (successresponse.error === true) {
if (successresponse.messages) {
Joomla.renderMessages(successresponse.messages);
Joomla.loadOptions({'csrf.token': successresponse.token});
} else {
// Stuff went wrong. No error messages. Just panic bail!
Joomla.renderMessages({error:['Unknown error deleting the installation folder.']});
}
} else {
const customInstallation = document.getElementById('customInstallation');
customInstallation.parentNode.removeChild(customInstallation);

const automatedUpdates = document.getElementById('automatedUpdates');

// This will only exist if it has not been removed with a previous step
if (automatedUpdates) {
automatedUpdates.parentNode.removeChild(automatedUpdates);
}

const removeInstallationTab = document.getElementById('removeInstallationTab');

// This will only exist in debug mode
if (removeInstallationTab) {
removeInstallationTab.parentNode.removeChild(removeInstallationTab);
}

if (redirectUrl) {
window.location.href = redirectUrl;
}
}
},
onError: function (xhr) {
Joomla.renderMessages(Joomla.ajaxErrorsMessages(xhr));
Joomla.request({
method: "POST",
url: Joomla.installationBaseUrl + '?task=installation.removeFolder&format=json',
perform: true,
token: true,
headers: { 'Content-Type': 'application/x-www-form-urlencoded' },
onSuccess: function (response) {
// If the installation folder has been deleted at least partly, i.e. also
// in case of a failure, we cannot use it anymore.
// Therefore set a marker in the admin and site buttons so they still work
// and disable buttons which will not work anymore.
completeInstallationOptions.forEach(function (item) {
item.dataset.installremoved = 'true';
});
if (document.getElementById('installAddFeatures')) {
document.getElementById('installAddFeatures').disabled = true;
}
if (document.getElementById('automatedUpdatesDisableButton')) {
document.getElementById('automatedUpdatesDisableButton').disabled = true;
}
if (document.getElementById('removeInstallationFolder')) {
document.getElementById('removeInstallationFolder').disabled = true;
}
const successresponse = JSON.parse(response);
if (successresponse.error === true) {
if (successresponse.messages) {
Joomla.renderMessages(successresponse.messages);
Joomla.loadOptions({ 'csrf.token': successresponse.token });
} else {
// Stuff went wrong. No error messages. Just panic bail!
Joomla.renderMessages({ error: ['Unknown error deleting the installation folder.'] });
}
});
} else {
const customInstallation = document.getElementById('customInstallation');
customInstallation.parentNode.removeChild(customInstallation);

const automatedUpdates = document.getElementById('automatedUpdates');

// This will only exist if it has not been removed with a previous step
if (automatedUpdates) {
automatedUpdates.parentNode.removeChild(automatedUpdates);
}

const removeInstallationTab = document.getElementById('removeInstallationTab');

// This will only exist in debug mode
if (removeInstallationTab) {
removeInstallationTab.parentNode.removeChild(removeInstallationTab);
}

if (redirectUrl) {
window.location.href = redirectUrl;
}
}
},
onError: function (xhr) {
Joomla.renderMessages(Joomla.ajaxErrorsMessages(xhr));
}
});
}

if (document.getElementById('installLanguagesButton')) {
document.getElementById('installLanguagesButton').addEventListener('click', function(e) {
e.preventDefault();
var form = document.getElementById('languagesForm');
if (form) {
// Install the extra languages
if (Joomla.install(['languages'], form)) {
document.getElementById('installLanguages').classList.remove('active');
document.getElementById('installFinal').classList.add('active');
}
}
})
document.getElementById('installLanguagesButton').addEventListener('click', function (e) {
e.preventDefault();
var form = document.getElementById('languagesForm');
if (form) {
// Install the extra languages
if (Joomla.install(['languages'], form)) {
document.getElementById('installLanguages').classList.remove('active');
document.getElementById('installFinal').classList.add('active');
}
}
})
}

if (document.getElementById('defaultLanguagesButton')) {
Expand Down Expand Up @@ -201,7 +206,7 @@ if (document.getElementById('defaultLanguagesButton')) {
if (successresponse.messages) {
Joomla.renderMessages(successresponse.messages, '#system-message-container');
}
Joomla.loadOptions({'csrf.token': successresponse.token});
Joomla.loadOptions({ 'csrf.token': successresponse.token });
},
onError(xhr) {
Joomla.renderMessages(Joomla.ajaxErrorsMessages(xhr));
Expand Down
Loading