Skip to content

Conversation

HLeithner
Copy link
Member

Add PHP 8.5 to ci.

@laoneo
Copy link
Member

laoneo commented Oct 3, 2025

I guess it needs also the cypress8.5 docker image. I created the branch, but not the required changes yet.

@HLeithner
Copy link
Member Author

I know, but hadn't the time yet. Will come next

@HLeithner
Copy link
Member Author

Ok I checked, php 8.5 for debian/our cypress docker container and I don't have the time to compile and maintain this my self I would suggest to merger this after 5.4 final release and wait for the excellent php 8.5 packages provided on https://deb.sury.org by @oerdnj (thanks for all your work Ondřej).

@HLeithner HLeithner added the bug label Oct 15, 2025
@richard67
Copy link
Member

richard67 commented Oct 15, 2025

System tests will be done with another PR?

Update 2025-10-17: They have been added meanwhile to this PR.

@richard67
Copy link
Member

After the recent fixed and dependency updates in the 5.4-dev branch for the PHP 8.5 deprecations, it seems there is only this one missing for making system tests pass:

PHP Deprecated:  The __sleep() serialization magic method has been deprecated. Implement __serialize() instead (or in addition, if support for old PHP versions is necessary) in /tests/www/cmysqlmax...

It comes from test cli/Session.cy.js.

@heelc29
Copy link
Contributor

heelc29 commented Oct 17, 2025

After the recent fixed and dependency updates in the 5.4-dev branch for the PHP 8.5 deprecations, it seems there is only this one missing for making system tests pass:

PHP Deprecated:  The __sleep() serialization magic method has been deprecated. Implement __serialize() instead (or in addition, if support for old PHP versions is necessary) in /tests/www/cmysqlmax...

It comes from test cli/Session.cy.js.

Here we need php8.5.0rc2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants