-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] redesigned media-browser-actions-list #24423
Conversation
New display works here. Is it what admin template workgroup desires? @ciar4n |
is this Test using Patchtester? |
I did style the original media manager UI for the old template design but I'm not part of the @rdeutz template group. Last I checked that group was private. So short answer.. I don't know. IMO since the template design has changed, the media manager looks out of place with the rest of the template and needs a total overhaul. But any changes is probably pointless IF this is been worked elsewhere. |
@franz-wohlkoenig Not possible to test with patchtester |
@ciar4n thanks, can you please provide a Link how to use NPM? Haven't found at https://docs.joomla.org/Special:MyLanguage/Portal:Joomla!_Code_Contributors |
Follow the link in the reader for j4 which takes you to You can only do this on a local environment. It is not possible on a remote like launch.joomla.org |
@franz-wohlkoenig you can run |
@brianteeman thanks for Links and Info. I updated the Test Instructions so non-Dev know how to test. If this is fine, i would append this Informations on all PR which need NPM for test. |
@ciar4n it's public now ;) https://github.com/joomla/backend-template/tree/release (make sure you're on the release branch if you clone down). but no they haven't worked on the media manager |
I don't think this is going to be acceptable from an a11y perspective @brianteeman @zwiastunsw as i assume all the elements need to be in the same |
@wilsonge thats correct but it can be resolved very easily - you can display a single list in two columns with just css using the html5 columns styling https://www.w3.org/TR/css-multicol-1/ |
OK Let's do that then. @bahl24 can you do the columns in CSS then please |
Alternative PR to joomla#24423 With the icons in 1 column they break out of the image and hover over the next row. This pr splits the list into 2 columns. This is done purely with css. It is still just one list so there is no a11y issue.
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/24423 |
Closing in favor of #25123 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24423. |
Alternative PR to #24423 With the icons in 1 column they break out of the image and hover over the next row. This pr splits the list into 2 columns. This is done purely with css. It is still just one list so there is no a11y issue.
Alternative PR to joomla#24423 With the icons in 1 column they break out of the image and hover over the next row. This pr splits the list into 2 columns. This is done purely with css. It is still just one list so there is no a11y issue.
Pull Request for Issue #joomla-projects/media-manager-improvement#567.
Will also help to solve #23968
Summary of Changes
Small changes in actions - list
Testing Instructions
Build vue files & clear cache.
This Pull Request can only be tested by NPM only on a local environment and not by using Patchtester.