Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] redesigned media-browser-actions-list #24423

Closed
wants to merge 1 commit into from

Conversation

bahl24
Copy link
Contributor

@bahl24 bahl24 commented Mar 31, 2019

Pull Request for Issue #joomla-projects/media-manager-improvement#567.

Will also help to solve #23968

Summary of Changes

Screenshot from 2019-03-25 15-26-38
Small changes in actions - list

Testing Instructions

Build vue files & clear cache.

This Pull Request can only be tested by NPM only on a local environment and not by using Patchtester.

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Mar 31, 2019
@joomla-cms-bot joomla-cms-bot changed the title [4.0]redesigned media-browser-actions-list [4.0] redesigned media-browser-actions-list Mar 31, 2019
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev and removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Mar 31, 2019
@infograf768
Copy link
Member

New display works here. Is it what admin template workgroup desires? @ciar4n

@ghost
Copy link

ghost commented Mar 31, 2019

is this Test using Patchtester?

@ciar4n
Copy link
Contributor

ciar4n commented Mar 31, 2019

I did style the original media manager UI for the old template design but I'm not part of the @rdeutz template group. Last I checked that group was private. So short answer.. I don't know.

IMO since the template design has changed, the media manager looks out of place with the rest of the template and needs a total overhaul. But any changes is probably pointless IF this is been worked elsewhere.

@ciar4n
Copy link
Contributor

ciar4n commented Mar 31, 2019

@franz-wohlkoenig Not possible to test with patchtester

@ghost
Copy link

ghost commented Mar 31, 2019

@ciar4n thanks, can you please provide a Link how to use NPM? Haven't found at https://docs.joomla.org/Special:MyLanguage/Portal:Joomla!_Code_Contributors

@brianteeman
Copy link
Contributor

Follow the link in the reader for j4 which takes you to
https://docs.joomla.org/J4.x:Setting_Up_Your_Local_Environment

You can only do this on a local environment. It is not possible on a remote like launch.joomla.org

@bahl24
Copy link
Contributor Author

bahl24 commented Mar 31, 2019

@franz-wohlkoenig you can run npm run dev in administrator/components/com_media folder & then clear browser cache after applying the patch.

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev and removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Mar 31, 2019
@ghost
Copy link

ghost commented Mar 31, 2019

@brianteeman thanks for Links and Info.

I updated the Test Instructions so non-Dev know how to test. If this is fine, i would append this Informations on all PR which need NPM for test.

@wilsonge
Copy link
Contributor

wilsonge commented Apr 2, 2019

@ciar4n it's public now ;) https://github.com/joomla/backend-template/tree/release (make sure you're on the release branch if you clone down). but no they haven't worked on the media manager

@wilsonge
Copy link
Contributor

I don't think this is going to be acceptable from an a11y perspective @brianteeman @zwiastunsw as i assume all the elements need to be in the same ul element

@brianteeman
Copy link
Contributor

@wilsonge thats correct but it can be resolved very easily - you can display a single list in two columns with just css using the html5 columns styling https://www.w3.org/TR/css-multicol-1/

@wilsonge
Copy link
Contributor

OK Let's do that then. @bahl24 can you do the columns in CSS then please

brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Jun 4, 2019
Alternative PR to joomla#24423

With the icons in 1 column they break out of the image and hover over the next row. This pr splits the list into 2 columns. This is done purely with css. It is still just one list so there is no a11y issue.
@joomla-cms-bot
Copy link

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/24423

@Quy
Copy link
Contributor

Quy commented Jun 4, 2019

Closing in favor of #25123


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24423.

wilsonge pushed a commit that referenced this pull request Jun 7, 2019
Alternative PR to #24423

With the icons in 1 column they break out of the image and hover over the next row. This pr splits the list into 2 columns. This is done purely with css. It is still just one list so there is no a11y issue.
brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Jun 10, 2019
Alternative PR to joomla#24423

With the icons in 1 column they break out of the image and hover over the next row. This pr splits the list into 2 columns. This is done purely with css. It is still just one list so there is no a11y issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants