You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The listed preset tags include search, which is not a standard HTML element, and summary, which is not suitable as a generic wrapper. Verify the preset list against the actual implementation and valid HTML elements.
The **moduletag** form field type provides a dropdown list of tags for a module wrapper. The preset list of tags includes address, article, aside, details, div, footer, header, main, nav, search, section and summary. Custom modules may specify additional tags.
Example adds fieldset and li as custom wrapper options; these are context-dependent and can lead to invalid markup for a module wrapper. Consider using context-agnostic container elements in examples.
Example adds figcaption, legend, label, and summary as custom header tags; these are not appropriate heading elements and can encourage invalid semantics. Use heading-related alternatives if demonstrating extensibility.
Consider the semantic appropriateness of these additional options for module titles. Some tags like 'legend' and 'summary' have specific semantic meanings that may not be suitable for general module titles.
Why: The suggestion correctly identifies that the example tags legend and summary are semantically inappropriate for a module title, and promoting correct semantics in documentation is important.
Low
Use appropriate wrapper tags
Ensure the additional tag examples are semantically appropriate for module wrappers. The 'form' tag should only be used when the module actually contains form elements to maintain proper HTML semantics.
Why: The suggestion correctly points out that using a form tag as a generic module wrapper is semantically incorrect, improving the quality of the documentation's examples.
Low
Clarify HTML tag terminology
Add clarity by specifying that these are HTML tags and explain the purpose of each tag type more clearly for better understanding.
-The **headertag** form field type provides a dropdown list of tags for a module title. The preset list of tags includes h1 to h6, p and div. Custom modules may specify additional tags.+The **headertag** form field type provides a dropdown list of HTML tags for a module title. The preset list includes semantic heading tags (h1 to h6), paragraph tag (p), and generic container (div). Custom modules may specify additional HTML tags.
Apply / Chat
Suggestion importance[1-10]: 4
__
Why: The suggestion improves documentation clarity by explicitly mentioning HTML tags and their purpose, which is helpful for users.
✅ Replace invalid example tagSuggestion Impact:The commit removed the li option from the example, addressing the invalid tag concern, though it did not replace it with span (used form instead).
Replace the li example with a tag that is valid standalone, since li is only valid inside lists. Using span avoids encouraging invalid HTML in examples.
Why: The suggestion correctly points out that using li as a module wrapper tag is invalid HTML, as it should only be a child of a list element, thus improving the example's correctness.
Low
✅ Avoid context-restricted tag in exampleSuggestion Impact:The commit added a span option to the list, aligning with the suggestion, but it did not remove the summary option; thus it partially implemented the suggestion.
Replace summary with a more appropriate inline element (e.g., span), since summary is only valid inside details and is not suitable for a header tag. This prevents examples from promoting invalid markup.
Why: The suggestion correctly identifies that summary is not a valid header tag as it's only valid within a details element, and proposing a change prevents an example that produces invalid HTML.
Low
Possible issue
✅ Remove invalid preset tagsSuggestion Impact:The commit updated the description to remove "search" and "summary" from the preset tags and rephrased the sentence, aligning with the suggestion’s intent.
code diff:
-The **moduletag** form field type provides a dropdown list of tags for a module wrapper. The preset list of tags includes address, article, aside, details, div, footer, header, main, nav, search, section and summary. Custom modules may specify additional tags.+The **moduletag** form field type provides a dropdown list of tags for a module wrapper. The preset list of tags includes most suitable wrapper tags: address, article, aside, details, div, footer, header, main, nav and section. Custom modules may specify additional tags.
Remove the non-standard HTML tag search and the context-restricted summary from the preset list to avoid encouraging invalid markup. Keep only valid, broadly applicable wrapper elements in the documented defaults.
-The **moduletag** form field type provides a dropdown list of tags for a module wrapper. The preset list of tags includes address, article, aside, details, div, footer, header, main, nav, search, section and summary. Custom modules may specify additional tags.+The **moduletag** form field type provides a dropdown list of tags for a module wrapper. The preset list of tags includes address, article, aside, details, div, footer, header, main, nav and section. Custom modules may specify additional tags.
[Suggestion processed]
Suggestion importance[1-10]: 5
__
Why: The suggestion correctly identifies that summary is not a valid general-purpose module wrapper tag, but incorrectly claims search is a non-standard tag.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Documentation
Description
Enhanced headertag field documentation with preset tags list
Enhanced moduletag field documentation with preset tags list
Added examples showing custom tag options
Updated field attribute descriptions for clarity
Diagram Walkthrough
File Walkthrough
headertag.md
Enhanced headertag field documentation with examplesdocs/general-concepts/forms-fields/standard-fields/headertag.md
moduletag.md
Enhanced moduletag field documentation with examplesdocs/general-concepts/forms-fields/standard-fields/moduletag.md
ametoname)