This repository has been archived by the owner on May 26, 2020. It is now read-only.
Change structure of create folder model. #579
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianteeman
reviewed
Oct 4, 2018
| @@ -59,6 +60,7 @@ COM_MEDIA_MEDIA_NAME="Name" | |||
| COM_MEDIA_MEDIA_SIZE="Size" | |||
| COM_MEDIA_MEDIA_TYPE="Type" | |||
| COM_MEDIA_NAME="Name" | |||
| COM_MEDIA_NEW_FOLDER="New folder" | |||
There was a problem hiding this comment.
Based on your screenshot I assume this should be New Folder
There was a problem hiding this comment.
I think, I not updated the screenshot. It's fine it should be small right ?
There was a problem hiding this comment.
It should be as in the screenshot
kasvith
reviewed
Oct 5, 2018
administrator/components/com_media/resources/scripts/components/modals/create-folder-modal.vue
Show resolved
Hide resolved
added 2 commits
October 5, 2018 11:33
laoneo
reviewed
Oct 5, 2018
| @@ -28,7 +27,7 @@ | |||
| directives: {focus: focus}, | |||
| data() { | |||
| return { | |||
| folder: '', | |||
| folder: 'Untitled folder', | |||
There was a problem hiding this comment.
Strings should be translated
|
@laoneo Any action on this ? |
|
The system test fails. Like that it can't be merged as it will cause problems when merging into upstream. @rdeutz how should the tests being adapted? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Changed some layouts of create folder model.
This is what I love.
If you guys also fine with this then merge.