This repository has been archived by the owner on May 26, 2020. It is now read-only.
Add save events for content plugins #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems nice |
Quy
reviewed
May 27, 2018
| @@ -4,6 +4,12 @@ | |||
| ; Note : All ini files need to be saved as UTF-8 | |||
|
|
|||
| PLG_MEDIA-ACTION_RESIZE="Media Action - Resize" | |||
| PLG_MEDIA-ACTION_RESIZE_BATCH_DESC="Settings for server side actions when images got created." | |||
Quy
reviewed
May 27, 2018
| @@ -4,6 +4,12 @@ | |||
| ; Note : All ini files need to be saved as UTF-8 | |||
|
|
|||
| PLG_MEDIA-ACTION_RESIZE="Media Action - Resize" | |||
| PLG_MEDIA-ACTION_RESIZE_BATCH_DESC="Settings for server side actions when images got created." | |||
| PLG_MEDIA-ACTION_RESIZE_BATCH_LABEL="Batch Settings" | |||
| PLG_MEDIA-ACTION_RESIZE_BATCH_MAX_HEIGHT_LABEL="Image Max Width" | |||
Quy
reviewed
May 27, 2018
| PLG_MEDIA-ACTION_RESIZE_BATCH_DESC="Settings for server side actions when images got created." | ||
| PLG_MEDIA-ACTION_RESIZE_BATCH_LABEL="Batch Settings" | ||
| PLG_MEDIA-ACTION_RESIZE_BATCH_MAX_HEIGHT_LABEL="Image Max Width" | ||
| PLG_MEDIA-ACTION_RESIZE_BATCH_MAX_HEIGHT_DESC="The maximum width an image can have. When empty, no resizing is performed." |
There was a problem hiding this comment.
Maybe this? The maximum height of an image to resize.
Quy
reviewed
May 27, 2018
| label="PLG_MEDIA-ACTION_RESIZE_BATCH_MAX_WIDTH_LABEL" | ||
| descripton="PLG_MEDIA-ACTION_RESIZE_BATCH_MAX_WIDTH_DESC" | ||
| addonAfter="px" | ||
| filter="int" |
There was a problem hiding this comment.
Reduce indent by 1.
filter="integer"
Quy
reviewed
May 27, 2018
| label="PLG_MEDIA-ACTION_RESIZE_BATCH_MAX_HEIGHT_LABEL" | ||
| descripton="PLG_MEDIA-ACTION_RESIZE_BATCH_MAX_HEIGHT_DESC" | ||
| addonAfter="px" | ||
| filter="int" |
There was a problem hiding this comment.
Reduce indent by 1.
filter="integer"
|
Thanks @Quy, made the changes. |
dgrammatiko
approved these changes
May 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #523.
Summary of Changes
A
onContentBeforeSaveandonContentAfterSaveevent gets triggered when a file is created or updated or when a folder is created. This includes also cloud adapters. The file data which is uploaded is sent in the event which can be modified by a plugin.This pr includes also two new batch settings for the resize plugin where the admin can define a max width and height for any image which gets uploaded.
Testing Instructions
Expected result
Image get resized to be not bigger than the defined values.
Actual result
No automatic resize is possible.