Skip to content

block &newline; entity in attribute filter to stop javascript: bypass #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arib06 wants to merge 1 commit into
base: 3.x-dev
Choose a base branch
from
Open

block &newline; entity in attribute filter to stop javascript: bypass #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions Tests/InputFilterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,6 +687,12 @@ public function casesGeneric()
'<img />',
'From generic cases',
],
'Kill script with newline entity' => [
'',
'<img src="java&NewLine;script:alert();" />',
'<img />',
'From generic cases',
],
'Nested tags' => [
'',
'<em><strong>Fred</strong></em>',
Expand Down Expand Up @@ -827,6 +833,12 @@ public function allowed()
'',
'From specific cases',
],
'Kill script with newline entity' => [
'',
'<img src="java&NewLine;script:alert();" />',
'',
'From specific cases',
],
'Nested tags' => [
'',
'<em><strong>Fred</strong></em>',
Expand Down Expand Up @@ -1005,6 +1017,12 @@ public function allowImg()
'<img />',
'From generic cases',
],
'Kill script with newline entity' => [
'',
'<img src="java&NewLine;script:alert();" />',
'<img />',
'From generic cases',
],
'Nested tags' => [
'',
'<em><strong>Fred</strong></em>',
Expand Down Expand Up @@ -1206,6 +1224,12 @@ public function allowClass()
'',
'From specific cases',
],
'Kill script with newline entity' => [
'',
'<img src="java&NewLine;script:alert();" />',
'',
'From specific cases',
],
'Nested tags' => [
'',
'<em><strong>Fred</strong></em>',
Expand Down Expand Up @@ -1742,6 +1766,12 @@ public function blockedImg()
'',
'From specific cases',
],
'Kill script with newline entity' => [
'',
'<img src="java&NewLine;script:alert();" />',
'',
'From specific cases',
],
'Unquoted Attribute Without Space' => [
'',
'<img height=300>',
Expand Down
1 change: 1 addition & 0 deletions src/InputFilter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ class InputFilter
*/
private $blockedChars = [
'&tab;',
'&newline;',
'&space;',
'&colon;',
'&column;',
Expand Down