Feature for amortized resizes #66
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlodato517
reviewed
Aug 20, 2020
Keep in mind that since this is a feature, _all_ evmap instances get amortized if _anything_ in the dependency graph enables the feature (indexmap-rs/indexmap#137 (comment)). This is unfortunate, but given that the alternative is forking evmap, we'll go with the feature approach for now. Hopefully one day we'll have a way to [avoid this](rust-lang/cargo#2980 (comment)). Not landing this yet since it's nightly-only at the moment due to certain methods [in `atone`](https://github.com/jonhoo/atone/blob/45ae1e42deaaaaa9a919957ade49982a7ac4655b/src/lib.rs#L58). Nightly-only will go away once rust-lang/rust#70929 and rust-lang/rust#74217 both stabilize. The first one will land on next stable, but the second has some more time to go first.
|
This has been folded into https://github.com/jonhoo/evmap and merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep in mind that since this is a feature, all evmap instances get amortized if anything in the dependency graph enables the feature (indexmap-rs/indexmap#137 (comment)). This is unfortunate, but given that the alternative is forking evmap, we'll go with the feature approach for now. Hopefully one day we'll have a way to avoid this.
Not landing this yet since it's nightly-only at the moment due to certain methods in
atone. Nightly-only will go away once rust-lang/rust#70929 and rust-lang/rust#74217 both stabilize. The first one will land on next stable, but the second has some more time to go first.This change is