Conversation
- Replace internal logging with azd-core/logutil re-exports - Replace internal cache with azd-core/cache.Manager - Replace version command with azd-core/version.NewCommand Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Prevents race condition in getManager() where concurrent goroutines could both see nil and create duplicate Manager instances. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sync.Once permanently caches initialization errors, leaving the package broken even on transient failures. sync.Mutex allows retry while still preventing concurrent double-initialization via check-then-act under lock. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Fix golangci-lint v2 issues (errcheck, staticcheck, revive) - Fix test reliability issues - All preflight checks now pass Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Website Preview
Preview has been cleaned up as the PR was closed. |
go.work with ../azd-core is for local dev only and breaks CI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CI runs from repo root but go.mod is in cli/. Add defaults working-directory and fix all path references from ./cli/src/ to ./src/. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate azd-copilot to use shared packages from azd-core, removing unnecessary wrapper packages.
Changes
azd-core/version.NewCommand()(keeps ldflags init)internal/logging/wrapper entirely,main.goimportsazd-core/logutildirectlyazd-core/cache.ManagerunderneathSecurity Fixes
getManager()race: replacedsync.Oncewithsync.Mutexfor retryable initialization (sync.Once permanently caches errors)Depends On
Quality